Completely remove Kubeops #5256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
✅ Deploy Preview for kubeapps-dev canceled.
|
beni0888
approved these changes
Sep 1, 2022
dashboard/src/shared/Auth.test.ts
Outdated
| @@ -279,7 +279,7 @@ describe("is403FromAuthProxy", () => { | |||
| expect( | |||
| Auth.is403FromAuthProxy({ | |||
| status: 403, | |||
| data: 'namespaces is forbidden: User "system:serviceaccount:kubeapps:kubeapps-internal-kubeops" cannot list resource "namespaces" in API group "" at the cluster scope', | |||
| data: 'namespaces is forbidden: User "system:serviceaccount:kubeapps:kubeapps-internal-kubeapps-apis" cannot list resource "namespaces" in API group "" at the cluster scope', | |||
There was a problem hiding this comment.
It seems there's a typo in either this or the following editions in this file. Note that we are using kubeapps-apis (with a hyphen) here, while we're using kubeappsapis in the rest of the occurrences.
There was a problem hiding this comment.
Good catch! It is a frontend test that actually checks if data points to a system:serviceaccount, so what comes after that is not used. But I'll update it to be consistent. Thanks.
added 2 commits
September 1, 2022 12:50
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
…pps into 4785-remove-kubeops-4 Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Completely remove Kubeops from the repo.
Only to be done after #5254
Benefits
Kubeapps repo is lighter, and less confusion on Kubeapps architecture.
Possible drawbacks
N/A
Applicable issues