Fix for E2E Carvel test 04 selectOption #5273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
✅ Deploy Preview for kubeapps-dev canceled.
|
antgamdia
reviewed
Sep 1, 2022
Comment on lines
+27
to
+28
| const versionSelector = await page.$('select[name="package-versions"]') | ||
| await versionSelector?.selectOption("2.0.0") |
There was a problem hiding this comment.
I think (not sure though) you can use the page.locator (which should auto-wait) and then use the selectOption, like
await page.locator("select[name="package-versions"]").selectOption("2.0.0");But, if your fix is proven to work, +1. Thanks for fixing it, it was generating some headaches recently!
There was a problem hiding this comment.
The underlying problem is not that the select control is not found, but that the option selected with selectOption was not being applied. Analyzing the failing tests dump shows that Kubeapps backend was receiving version 3.0.0-rc.1 (default one).
Let's see if this consistently fixes the problem, otherwise we'll have to try other approaches.
antgamdia
approved these changes
Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rafa Castelblanque rcastelblanq@vmware.com
Description of the change
Trivial PR trying to fix the error appearing with E2E test 04 for Carvel.
It is the typical error on E2E CI that fails from time to time, but I noticed that the frequency has been increasing lately.
Benefits
CI pipelines should pass successfully more often.
Possible drawbacks
That this PR does not really fix the issue.
Applicable issues