Use new K8s clients provider in Flux plugin #5379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 22, 2022 16:50
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
✅ Deploy Preview for kubeapps-dev ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
castelblanque
commented
Sep 22, 2022
Comment on lines
+238
to
+239
| config.QPS = clientQPS | ||
| config.Burst = clientBurst |
There was a problem hiding this comment.
Added qps and burst params to in-cluster/background clients provider.
antgamdia
approved these changes
Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Follow-up PR to #5358. In this case for Flux plugin.
Using the new clients provider with independent functions, so not all clients are created at once.
Specifically, when creating the
DynamicandControllerRuntimeclients, many requests are done at the same time againts K8s APIs. In the scenario of Pinniped, those requests are done againstpinniped-proxy, which proxies to the actual k8s API server. There is no throttling betweenkubeapps-apisandpinniped-proxy, as all clients count withqps/burstconfiguration. So if there is a throttling problem, it must be atpinniped-proxyagainst k8s API server. Maybe a connection pool limitation?Benefits
Should speed up a bit requests to Kubeapps APIs in the pinniped scenario.
Possible drawbacks
N/A
Applicable issues
Additional information
Added client
QPSandburstconfiguration to in-cluster clients too.