Fix codeql issue #5438
Merged
Fix codeql issue #5438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
✅ Deploy Preview for kubeapps-dev canceled.Built without sensitive environment variables
|
antgamdia
commented
Oct 6, 2022
Comment on lines
293
to
296
| // https://codeql.github.com/codeql-query-help/go/go-log-injection/ | ||
| escapedUrl := strings.Replace(fmt.Sprintf("%s", resp.Request.URL), "\n", "", -1) | ||
| escapedUrl = strings.Replace(escapedUrl, "\r", "", -1) | ||
| return fmt.Errorf("%s %q: unexpected status code %d: %s", resp.Request.Method, escapedUrl, resp.StatusCode, errmsg) |
There was a problem hiding this comment.
This is the actual change, the rest is just prettier
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This PR aims at solving the issue reported by CodeQl (see https://github.com/vmware-tanzu/kubeapps/security/code-scanning/29).
Benefits
No more CodeQL open issues
Possible drawbacks
N/A
Applicable issues
Additional information
Run prettier as well.