Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a11y-related issues on the website #5456

Merged
merged 27 commits into from Oct 17, 2022
Merged

Fix a11y-related issues on the website #5456

merged 27 commits into from Oct 17, 2022

Conversation

antgamdia
Copy link
Contributor

Description of the change

This PR is implementing the changes I detailed in #5397 (comment) + misc improvements/cleanup.

Benefits

The website will be more accessible to more users, as many a11y issues have been solved.

Possible drawbacks

N/A

Applicable issues

Additional information

There are some open issues, but they are awaiting for the a11y team to reply first.

@antgamdia
Add initial fixes
8980d6b 
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
@antgamdia
Run prettier
cc0349b 
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
@antgamdia
Fix a11y issue
7eaf9b2 
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
@antgamdia
Run prettier
42f06aa 
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
@antgamdia
Fix indentation consistency
eeed2f9 
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
@antgamdia
improve 404 page
b4806cf 
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
@antgamdia
Minor css fixes
11d2c8d 
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
@antgamdia
Generate md link titles
6ee0292 
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
@antgamdia
Add links to anchors
bf82423 
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
@antgamdia
Add title in links with img
bf7be16 
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
@antgamdia
Add more a11y fixes
c95c710 
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
@antgamdia
Increase heading <hX starting number
381d38f 
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
@antgamdia
Remove unused version selector (via param)
6a05bc0 
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
@antgamdia
Fix heading issues in menus
663a116 
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
@antgamdia
Add caption to tables
2078a69 
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
@antgamdia
Lazy load scripts for performance
c995a97 
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
@antgamdia
Fix a11y issue with anchors
bfbe2a8 
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
@antgamdia
Add hidden skip to main page button
127913d 
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
@antgamdia
Show right panel on medium screens
35da7d9 
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
@antgamdia
Add chevron to links
88fa34e 
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
@antgamdia
Fix async script issue
53800e6 
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
@antgamdia
Fix overflow search box
cfe3fdf 
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
@antgamdia
Use semantic tag for getting started
428f67c 
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
@antgamdia
Fix search title
74ed5e6 
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
@antgamdia
Add new new tab notice in link titles
caaed9d 
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
@antgamdia
Add title to anchor links
a6da5d3 
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
@netlify
Copy link

netlify bot commented Oct 12, 2022 •
edited

✅ Deploy Preview for kubeapps-dev canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 1361d6f
🔍 Latest deploy log https://app.netlify.com/sites/kubeapps-dev/deploys/634d2311b255a70008610d4f

castelblanque
castelblanque approved these changes Oct 17, 2022
View reviewed changes
Copy link
Collaborator

@castelblanque castelblanque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antgamdia antgamdia merged commit f8d20a2 into vmware-tanzu:main Oct 17, 2022
@antgamdia antgamdia deleted the fix-a11y-website branch October 17, 2022 10:57
absoludity pushed a commit that referenced this pull request Jan 18, 2023
@dependabot
Bump axios from 1.2.2 to 1.2.3 in /integration (#5889)
fd99788 
Bumps [axios](https://github.com/axios/axios) from 1.2.2 to 1.2.3.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/axios/axios/releases">axios's
releases</a>.</em></p>
<blockquote>
<h2>1.2.3</h2>
<h2>Release notes:</h2>
<h3>Bug Fixes</h3>
<ul>
<li><strong>types:</strong> fixed AxiosRequestConfig header interface by
refactoring it to RawAxiosRequestConfig; (<a
href="https://github-redirect.dependabot.com/axios/axios/issues/5420">#5420</a>)
(<a
href="https://github.com/axios/axios/commit/08119634a22f1d5b19f5c9ea0adccb6d3eebc3bc">0811963</a>)</li>
</ul>
<h3>Contributors to this release</h3>
<ul>
<li><img
src="https://avatars.githubusercontent.com/u/12586868?v=4&amp;s=16"
alt="avatar" /> <a href="https://github.com/DigitalBrainJS"
title="+938/-442 ([#5456](axios/axios#5456)
[#5455](axios/axios#5455)
[#5453](axios/axios#5453)
[#5451](axios/axios#5451)
[#5449](axios/axios#5449)
[#5447](axios/axios#5447)
[#5446](axios/axios#5446)
[#5443](axios/axios#5443)
[#5442](axios/axios#5442)
[#5439](axios/axios#5439)
[#5420](axios/axios#5420) )">Dmitriy
Mozgovoy</a></li>
</ul>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/axios/axios/blob/v1.x/CHANGELOG.md">axios's
changelog</a>.</em></p>
<blockquote>
<h2><a
href="https://github.com/axios/axios/compare/1.2.2...1.2.3">1.2.3</a>
(2023-01-10)</h2>
<h3>Bug Fixes</h3>
<ul>
<li><strong>types:</strong> fixed AxiosRequestConfig header interface by
refactoring it to RawAxiosRequestConfig; (<a
href="https://github-redirect.dependabot.com/axios/axios/issues/5420">#5420</a>)
(<a
href="https://github.com/axios/axios/commit/08119634a22f1d5b19f5c9ea0adccb6d3eebc3bc">0811963</a>)</li>
</ul>
<h3>Contributors to this release</h3>
<ul>
<li><img
src="https://avatars.githubusercontent.com/u/12586868?v=4&amp;s=16"
alt="avatar" /> <a href="https://github.com/DigitalBrainJS"
title="+938/-442 ([#5456](axios/axios#5456)
[#5455](axios/axios#5455)
[#5453](axios/axios#5453)
[#5451](axios/axios#5451)
[#5449](axios/axios#5449)
[#5447](axios/axios#5447)
[#5446](axios/axios#5446)
[#5443](axios/axios#5443)
[#5442](axios/axios#5442)
[#5439](axios/axios#5439)
[#5420](axios/axios#5420) )">Dmitriy
Mozgovoy</a></li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/axios/axios/commit/557ed0a7489b1bf62296ea34568eeea8975ff4f9"><code>557ed0a</code></a>
chore(ci): fixed publish action; (<a
href="https://github-redirect.dependabot.com/axios/axios/issues/5470">#5470</a>)</li>
<li><a
href="https://github.com/axios/axios/commit/484e0b6ed24745df9cadaacc0fbf129114e70d00"><code>484e0b6</code></a>
chore(release): v1.2.3 (<a
href="https://github-redirect.dependabot.com/axios/axios/issues/5459">#5459</a>)</li>
<li><a
href="https://github.com/axios/axios/commit/d83316db4a242252db3a2ed7728cb43f8f8f4189"><code>d83316d</code></a>
chore(ci): enabled npm publishing; (<a
href="https://github-redirect.dependabot.com/axios/axios/issues/5460">#5460</a>)</li>
<li><a
href="https://github.com/axios/axios/commit/d750901deda2994a2d89643e8f18723cfb6b2732"><code>d750901</code></a>
chore(ci): added an action to make GitHub &amp; NPM releases when
merging a relea...</li>
<li><a
href="https://github.com/axios/axios/commit/477c71427dc1d03e0f3dced0d65bd7c1b99fd900"><code>477c714</code></a>
chore(ci): fixed error in generating changelog with unnecessary spaces;
(<a
href="https://github-redirect.dependabot.com/axios/axios/issues/5455">#5455</a>)</li>
<li><a
href="https://github.com/axios/axios/commit/e2a1e280f6dfbb4f11ad541dec9541cdbf760ab1"><code>e2a1e28</code></a>
chore(ci): improved contributors &amp; PRs sections generator; (<a
href="https://github-redirect.dependabot.com/axios/axios/issues/5453">#5453</a>)</li>
<li><a
href="https://github.com/axios/axios/commit/18772ed8fdcd0768a9b520737d81283c04a273f8"><code>18772ed</code></a>
chore(ci): improved logging; (<a
href="https://github-redirect.dependabot.com/axios/axios/issues/5451">#5451</a>)</li>
<li><a
href="https://github.com/axios/axios/commit/259f5f5aaadfcaf7f3a3fe462d8b0dbbc8004962"><code>259f5f5</code></a>
chore(ci): added step of generating a list of contributors for
CHANELOG.md; (...</li>
<li><a
href="https://github.com/axios/axios/commit/d33a3deb82b808f109b598abbf39fd2a1f8da998"><code>d33a3de</code></a>
chore(ci): added commit message config; (<a
href="https://github-redirect.dependabot.com/axios/axios/issues/5447">#5447</a>)</li>
<li><a
href="https://github.com/axios/axios/commit/ebb9e814436d2f6c7cc65ffecb6ff013539ce961"><code>ebb9e81</code></a>
chore(deps): bump json5 from 1.0.1 to 1.0.2 (<a
href="https://github-redirect.dependabot.com/axios/axios/issues/5438">#5438</a>)</li>
<li>Additional commits viewable in <a
href="https://github.com/axios/axios/compare/1.2.2...v1.2.3">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=axios&package-manager=npm_and_yarn&previous-version=1.2.2&new-version=1.2.3)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
absoludity pushed a commit that referenced this pull request Jan 20, 2023
@dependabot
Bump axios from 1.2.2 to 1.2.3 in /dashboard (#5890)
98f5cd8 
Bumps [axios](https://github.com/axios/axios) from 1.2.2 to 1.2.3.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/axios/axios/releases">axios's
releases</a>.</em></p>
<blockquote>
<h2>1.2.3</h2>
<h2>Release notes:</h2>
<h3>Bug Fixes</h3>
<ul>
<li><strong>types:</strong> fixed AxiosRequestConfig header interface by
refactoring it to RawAxiosRequestConfig; (<a
href="https://github-redirect.dependabot.com/axios/axios/issues/5420">#5420</a>)
(<a
href="https://github.com/axios/axios/commit/08119634a22f1d5b19f5c9ea0adccb6d3eebc3bc">0811963</a>)</li>
</ul>
<h3>Contributors to this release</h3>
<ul>
<li><img
src="https://avatars.githubusercontent.com/u/12586868?v=4&amp;s=16"
alt="avatar" /> <a href="https://github.com/DigitalBrainJS"
title="+938/-442 ([#5456](axios/axios#5456)
[#5455](axios/axios#5455)
[#5453](axios/axios#5453)
[#5451](axios/axios#5451)
[#5449](axios/axios#5449)
[#5447](axios/axios#5447)
[#5446](axios/axios#5446)
[#5443](axios/axios#5443)
[#5442](axios/axios#5442)
[#5439](axios/axios#5439)
[#5420](axios/axios#5420) )">Dmitriy
Mozgovoy</a></li>
</ul>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/axios/axios/blob/v1.x/CHANGELOG.md">axios's
changelog</a>.</em></p>
<blockquote>
<h2><a
href="https://github.com/axios/axios/compare/1.2.2...1.2.3">1.2.3</a>
(2023-01-10)</h2>
<h3>Bug Fixes</h3>
<ul>
<li><strong>types:</strong> fixed AxiosRequestConfig header interface by
refactoring it to RawAxiosRequestConfig; (<a
href="https://github-redirect.dependabot.com/axios/axios/issues/5420">#5420</a>)
(<a
href="https://github.com/axios/axios/commit/08119634a22f1d5b19f5c9ea0adccb6d3eebc3bc">0811963</a>)</li>
</ul>
<h3>Contributors to this release</h3>
<ul>
<li><img
src="https://avatars.githubusercontent.com/u/12586868?v=4&amp;s=16"
alt="avatar" /> <a href="https://github.com/DigitalBrainJS"
title="+938/-442 ([#5456](axios/axios#5456)
[#5455](axios/axios#5455)
[#5453](axios/axios#5453)
[#5451](axios/axios#5451)
[#5449](axios/axios#5449)
[#5447](axios/axios#5447)
[#5446](axios/axios#5446)
[#5443](axios/axios#5443)
[#5442](axios/axios#5442)
[#5439](axios/axios#5439)
[#5420](axios/axios#5420) )">Dmitriy
Mozgovoy</a></li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/axios/axios/commit/557ed0a7489b1bf62296ea34568eeea8975ff4f9"><code>557ed0a</code></a>
chore(ci): fixed publish action; (<a
href="https://github-redirect.dependabot.com/axios/axios/issues/5470">#5470</a>)</li>
<li><a
href="https://github.com/axios/axios/commit/484e0b6ed24745df9cadaacc0fbf129114e70d00"><code>484e0b6</code></a>
chore(release): v1.2.3 (<a
href="https://github-redirect.dependabot.com/axios/axios/issues/5459">#5459</a>)</li>
<li><a
href="https://github.com/axios/axios/commit/d83316db4a242252db3a2ed7728cb43f8f8f4189"><code>d83316d</code></a>
chore(ci): enabled npm publishing; (<a
href="https://github-redirect.dependabot.com/axios/axios/issues/5460">#5460</a>)</li>
<li><a
href="https://github.com/axios/axios/commit/d750901deda2994a2d89643e8f18723cfb6b2732"><code>d750901</code></a>
chore(ci): added an action to make GitHub &amp; NPM releases when
merging a relea...</li>
<li><a
href="https://github.com/axios/axios/commit/477c71427dc1d03e0f3dced0d65bd7c1b99fd900"><code>477c714</code></a>
chore(ci): fixed error in generating changelog with unnecessary spaces;
(<a
href="https://github-redirect.dependabot.com/axios/axios/issues/5455">#5455</a>)</li>
<li><a
href="https://github.com/axios/axios/commit/e2a1e280f6dfbb4f11ad541dec9541cdbf760ab1"><code>e2a1e28</code></a>
chore(ci): improved contributors &amp; PRs sections generator; (<a
href="https://github-redirect.dependabot.com/axios/axios/issues/5453">#5453</a>)</li>
<li><a
href="https://github.com/axios/axios/commit/18772ed8fdcd0768a9b520737d81283c04a273f8"><code>18772ed</code></a>
chore(ci): improved logging; (<a
href="https://github-redirect.dependabot.com/axios/axios/issues/5451">#5451</a>)</li>
<li><a
href="https://github.com/axios/axios/commit/259f5f5aaadfcaf7f3a3fe462d8b0dbbc8004962"><code>259f5f5</code></a>
chore(ci): added step of generating a list of contributors for
CHANELOG.md; (...</li>
<li><a
href="https://github.com/axios/axios/commit/d33a3deb82b808f109b598abbf39fd2a1f8da998"><code>d33a3de</code></a>
chore(ci): added commit message config; (<a
href="https://github-redirect.dependabot.com/axios/axios/issues/5447">#5447</a>)</li>
<li><a
href="https://github.com/axios/axios/commit/ebb9e814436d2f6c7cc65ffecb6ff013539ce961"><code>ebb9e81</code></a>
chore(deps): bump json5 from 1.0.1 to 1.0.2 (<a
href="https://github-redirect.dependabot.com/axios/axios/issues/5438">#5438</a>)</li>
<li>Additional commits viewable in <a
href="https://github.com/axios/axios/compare/1.2.2...v1.2.3">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=axios&package-manager=npm_and_yarn&previous-version=1.2.2&new-version=1.2.3)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@castelblanque castelblanque castelblanque approved these changes

Assignees
No one assigned
Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Accessibility compliance for kubeapps.dev
3 participants
@antgamdia @castelblanque @vmwclabot