Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip non-image files when loading docker images in local_e2e_tests #5465

Merged
merged 1 commit into from Oct 17, 2022

Conversation

beni0888
Copy link
Collaborator

Signed-off-by: Jesús Benito Calzada bjesus@vmware.com

Description of the change

The changes in this PR aim to fix the error raised in the local_e2e_tests job of the GitHub Actions "kubeapps general workflow", where it's failing because it's trying to docker-load a non-image artifact.

Benefits

The local_e2e_tests job of the GHA workflow should no longer fail for the reason mentioned above.

Possible drawbacks

None

Applicable issues

Additional information

Signed-off-by: Jesús Benito Calzada <bjesus@vmware.com>
@beni0888 beni0888 added kind/bug An issue that reports a defect in an existing feature component/ci Issue related to kubeapps ci system github_actions Pull requests that update GitHub Actions code labels Oct 17, 2022
@beni0888 beni0888 added this to the Migrate CI to GitHub Actions milestone Oct 17, 2022
@beni0888 beni0888 self-assigned this Oct 17, 2022
@netlify
Copy link

netlify bot commented Oct 17, 2022

Deploy Preview for kubeapps-dev canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit e757017
🔍 Latest deploy log https://app.netlify.com/sites/kubeapps-dev/deploys/634cfb65d9c4180009421e7c

@beni0888 beni0888 marked this pull request as ready for review October 17, 2022 06:51
Copy link
Collaborator

@castelblanque castelblanque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@beni0888 beni0888 merged commit 6386930 into vmware-tanzu:main Oct 17, 2022
@beni0888 beni0888 deleted the fix-local-e2e-tests branch October 17, 2022 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-not-required component/ci Issue related to kubeapps ci system github_actions Pull requests that update GitHub Actions code kind/bug An issue that reports a defect in an existing feature
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants