Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Helm plugin] Remove unnecessary context check #5504

Merged
merged 1 commit into from Oct 19, 2022

Conversation

castelblanque
Copy link
Collaborator

@castelblanque castelblanque commented Oct 19, 2022

Signed-off-by: Rafa Castelblanque rcastelblanq@vmware.com

Description of the change

Trivial PR removing unneeded checks for provided context cluster.
Cluster is not strictly required, as it will fall back to the Kubeapps cluster if not specified. See code in charge here.

Otherwise, an error like this was returned:

ERROR:
  Code: InvalidArgument
  Message: Invalid GetPackageRepositorySummaries response from the plugin helm.packages: rpc error: code = InvalidArgument desc = no valid context provided

Benefits

Specify cluster context for operations in Helm plugin is not required.

Possible drawbacks

N/A

Applicable issues

N/A

Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
@netlify
Copy link

netlify bot commented Oct 19, 2022

Deploy Preview for kubeapps-dev ready!

Name Link
🔨 Latest commit e1a61a6
🔍 Latest deploy log https://app.netlify.com/sites/kubeapps-dev/deploys/6350008597422200097d4e7d
😎 Deploy Preview https://deploy-preview-5504--kubeapps-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@castelblanque castelblanque changed the title [Helm plugin ] Remove unnecessary context check [Helm plugin] Remove unnecessary context check Oct 19, 2022
Copy link
Contributor

@antgamdia antgamdia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@castelblanque castelblanque merged commit b14f333 into main Oct 19, 2022
@castelblanque castelblanque deleted the 5468-remove-ctx-check branch October 19, 2022 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants