Avoid docker production images overlapping between GHA and CircleCI #5528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…from GHA in DEV_MODE Signed-off-by: Jesús Benito Calzada <bjesus@vmware.com>
beni0888
added
component/ci
✅ Deploy Preview for kubeapps-dev canceled.Built without sensitive environment variables
|
30 tasks
… job (the production ones) Signed-off-by: Jesús Benito Calzada <bjesus@vmware.com>
Signed-off-by: Jesús Benito Calzada <bjesus@vmware.com>
Signed-off-by: Jesús Benito Calzada <bjesus@vmware.com>
absoludity
pushed a commit
that referenced
this pull request
Feb 7, 2023
Bumps [axios](https://github.com/axios/axios) from 1.3.1 to 1.3.2. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/axios/axios/releases">axios's releases</a>.</em></p> <blockquote> <h2>Release v1.3.2</h2> <h2>Release notes:</h2> <h3>Bug Fixes</h3> <ul> <li><strong>http:</strong> treat <a href="http://localhost">http://localhost</a> as base URL for relative paths to avoid <code>ERR_INVALID_URL</code> error; (<a href="https://github-redirect.dependabot.com/axios/axios/issues/5528">#5528</a>) (<a href="https://github.com/axios/axios/commit/128d56f4a0fb8f5f2ed6e0dd80bc9225fee9538c">128d56f</a>)</li> <li><strong>http:</strong> use explicit import instead of TextEncoder global; (<a href="https://github-redirect.dependabot.com/axios/axios/issues/5530">#5530</a>) (<a href="https://github.com/axios/axios/commit/6b3c305fc40c56428e0afabedc6f4d29c2830f6f">6b3c305</a>)</li> </ul> <h3>Contributors to this release</h3> <ul> <li><!-- raw HTML omitted --> <a href="https://github.com/DigitalBrainJS" title="+2/-1 ([#5530](axios/axios#5530) [#5528](axios/axios#5528) )">Dmitriy Mozgovoy</a></li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/axios/axios/blob/v1.x/CHANGELOG.md">axios's changelog</a>.</em></p> <blockquote> <h2><a href="https://github.com/axios/axios/compare/v1.3.1...v1.3.2">1.3.2</a> (2023-02-03)</h2> <h3>Bug Fixes</h3> <ul> <li><strong>http:</strong> treat <a href="http://localhost">http://localhost</a> as base URL for relative paths to avoid <code>ERR_INVALID_URL</code> error; (<a href="https://github-redirect.dependabot.com/axios/axios/issues/5528">#5528</a>) (<a href="https://github.com/axios/axios/commit/128d56f4a0fb8f5f2ed6e0dd80bc9225fee9538c">128d56f</a>)</li> <li><strong>http:</strong> use explicit import instead of TextEncoder global; (<a href="https://github-redirect.dependabot.com/axios/axios/issues/5530">#5530</a>) (<a href="https://github.com/axios/axios/commit/6b3c305fc40c56428e0afabedc6f4d29c2830f6f">6b3c305</a>)</li> </ul> <h3>Contributors to this release</h3> <ul> <li><!-- raw HTML omitted --> <a href="https://github.com/DigitalBrainJS" title="+2/-1 ([#5530](axios/axios#5530) [#5528](axios/axios#5528) )">Dmitriy Mozgovoy</a></li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/axios/axios/commit/0b449293fc238f30f39ab9ed0fca86a23c8a6a79"><code>0b44929</code></a> chore(release): v1.3.2 (<a href="https://github-redirect.dependabot.com/axios/axios/issues/5531">#5531</a>)</li> <li><a href="https://github.com/axios/axios/commit/6b3c305fc40c56428e0afabedc6f4d29c2830f6f"><code>6b3c305</code></a> fix(http): use explicit import instead of TextEncoder global; (<a href="https://github-redirect.dependabot.com/axios/axios/issues/5530">#5530</a>)</li> <li><a href="https://github.com/axios/axios/commit/128d56f4a0fb8f5f2ed6e0dd80bc9225fee9538c"><code>128d56f</code></a> fix(http): treat <a href="http://localhost">http://localhost</a> as base URL for relative paths to avoid `ER...</li> <li>See full diff in <a href="https://github.com/axios/axios/compare/v1.3.1...v1.3.2">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
absoludity
pushed a commit
that referenced
this pull request
Feb 9, 2023
Bumps [axios](https://github.com/axios/axios) from 1.3.1 to 1.3.2. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/axios/axios/releases">axios's releases</a>.</em></p> <blockquote> <h2>Release v1.3.2</h2> <h2>Release notes:</h2> <h3>Bug Fixes</h3> <ul> <li><strong>http:</strong> treat <a href="http://localhost">http://localhost</a> as base URL for relative paths to avoid <code>ERR_INVALID_URL</code> error; (<a href="https://github-redirect.dependabot.com/axios/axios/issues/5528">#5528</a>) (<a href="https://github.com/axios/axios/commit/128d56f4a0fb8f5f2ed6e0dd80bc9225fee9538c">128d56f</a>)</li> <li><strong>http:</strong> use explicit import instead of TextEncoder global; (<a href="https://github-redirect.dependabot.com/axios/axios/issues/5530">#5530</a>) (<a href="https://github.com/axios/axios/commit/6b3c305fc40c56428e0afabedc6f4d29c2830f6f">6b3c305</a>)</li> </ul> <h3>Contributors to this release</h3> <ul> <li><!-- raw HTML omitted --> <a href="https://github.com/DigitalBrainJS" title="+2/-1 ([#5530](axios/axios#5530) [#5528](axios/axios#5528) )">Dmitriy Mozgovoy</a></li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/axios/axios/blob/v1.x/CHANGELOG.md">axios's changelog</a>.</em></p> <blockquote> <h2><a href="https://github.com/axios/axios/compare/v1.3.1...v1.3.2">1.3.2</a> (2023-02-03)</h2> <h3>Bug Fixes</h3> <ul> <li><strong>http:</strong> treat <a href="http://localhost">http://localhost</a> as base URL for relative paths to avoid <code>ERR_INVALID_URL</code> error; (<a href="https://github-redirect.dependabot.com/axios/axios/issues/5528">#5528</a>) (<a href="https://github.com/axios/axios/commit/128d56f4a0fb8f5f2ed6e0dd80bc9225fee9538c">128d56f</a>)</li> <li><strong>http:</strong> use explicit import instead of TextEncoder global; (<a href="https://github-redirect.dependabot.com/axios/axios/issues/5530">#5530</a>) (<a href="https://github.com/axios/axios/commit/6b3c305fc40c56428e0afabedc6f4d29c2830f6f">6b3c305</a>)</li> </ul> <h3>Contributors to this release</h3> <ul> <li><!-- raw HTML omitted --> <a href="https://github.com/DigitalBrainJS" title="+2/-1 ([#5530](axios/axios#5530) [#5528](axios/axios#5528) )">Dmitriy Mozgovoy</a></li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/axios/axios/commit/0b449293fc238f30f39ab9ed0fca86a23c8a6a79"><code>0b44929</code></a> chore(release): v1.3.2 (<a href="https://github-redirect.dependabot.com/axios/axios/issues/5531">#5531</a>)</li> <li><a href="https://github.com/axios/axios/commit/6b3c305fc40c56428e0afabedc6f4d29c2830f6f"><code>6b3c305</code></a> fix(http): use explicit import instead of TextEncoder global; (<a href="https://github-redirect.dependabot.com/axios/axios/issues/5530">#5530</a>)</li> <li><a href="https://github.com/axios/axios/commit/128d56f4a0fb8f5f2ed6e0dd80bc9225fee9538c"><code>128d56f</code></a> fix(http): treat <a href="http://localhost">http://localhost</a> as base URL for relative paths to avoid `ER...</li> <li>See full diff in <a href="https://github.com/axios/axios/compare/v1.3.1...v1.3.2">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jesús Benito Calzada bjesus@vmware.com
Description of the change
Right now, when Docker production images are generated from the GHA kubeapps general workflow, those are pushed to Docker Hub in the
kubeappsworkspace (eg.kubeapps/kubeapps-apis,kubeapps/dashboard, etc) and tagged withlatestor the release versionx.y.z, so they overlap with the ones generated in the CircleCI workflow that runs in parallel (until we finish the migration to GHA and decommission the CircleCI workflow). To avoid images from both workflows to overwrite each other, this PR adds a-ghasuffix to the tag for the images generated from the GHA workflow (eg.kubeapps/dashboard:latest-gha).Also, I took advantage of this PR to fix the step
Show PR Contextfrom the GHA kubeapps general workflow'ssetupjob. This step is mainly for debugging purposes.Benefits
setupstep of the GHA kubeapps general workflow works as expected.Possible drawbacks
In case you want to use the images generated from GHA, you'll have to use a tag that doesn't follow the standard convention.
Applicable issues
Additional information