Part of the fix for a flux app in failed install state, deleted via UX, stays around in k8s flux HelmRelease CR #5577 #5584

gfichtenholt · 2022-10-28T06:15:48Z

fixed an inconsistency between GetInstalledPackageSummaries() and GetInstalledPackageDetail() in one corner case.
Main fix is dependent on flux fluxcd/helm-controller#554

There is only one small change to production code. The rest is test-related code. Also,

added a few integration tests.
bump flux version in tests
fix for available package handling with flux in multi-tenant mode available package handling with flux in multi-tenant mode #5541

netlify · 2022-10-28T06:16:03Z

✅ Deploy Preview for kubeapps-dev ready!

Built without sensitive environment variables

Name	Link
🔨 Latest commit	`864dffb`
🔍 Latest deploy log	https://app.netlify.com/sites/kubeapps-dev/deploys/6365cb4b627d2a0009839f50
😎 Deploy Preview	https://deploy-preview-5584--kubeapps-dev.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

…zu#5541

antgamdia

Great, thanks!

Just to prevent we forget about this param, I'd rather document it in the values.yaml + readme.md.

For instance, sth like:

    flux:
      packages:
        v1alpha1:
          ## @param kubeappsapis.pluginConfig.flux.packages.v1alpha1.defaultUpgradePolicy Default upgrade policy generating version constraints
          ## enum: [ "major", "minor", "patch", "none" ]
          defaultUpgradePolicy: none
            ## @param kubeappsapis.pluginConfig.flux.packages.v1alpha1.userManagedSecrets Default policy for handling repository secrets, either managed by the user or by kubeapps-apis
          userManagedSecrets: false
            ## @param kubeappsapis.pluginConfig.flux.packages.v1alpha1.userManagedSecrets Disable the cross-namespace references, useful when running Flux on multi-tenant clusters
          noCrossNamespaceRefs: false

Then, run the readme-generator tool to autogenerate the readme.md

gfichtenholt · 2022-11-04T15:34:19Z

Great, thanks!

Just to prevent we forget about this param, I'd rather document it in the values.yaml + readme.md.

For instance, sth like:

    flux:
      packages:
        v1alpha1:
          ## @param kubeappsapis.pluginConfig.flux.packages.v1alpha1.defaultUpgradePolicy Default upgrade policy generating version constraints
          ## enum: [ "major", "minor", "patch", "none" ]
          defaultUpgradePolicy: none
            ## @param kubeappsapis.pluginConfig.flux.packages.v1alpha1.userManagedSecrets Default policy for handling repository secrets, either managed by the user or by kubeapps-apis
          userManagedSecrets: false
            ## @param kubeappsapis.pluginConfig.flux.packages.v1alpha1.userManagedSecrets Disable the cross-namespace references, useful when running Flux on multi-tenant clusters
          noCrossNamespaceRefs: false

Then, run the readme-generator tool to autogenerate the readme.md

Thanks Antonio. Will do

Bumps [axios](https://github.com/axios/axios) from 1.3.4 to 1.3.5. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/axios/axios/releases">axios's releases</a>.</em></p> <blockquote> <h2>Release v1.3.5</h2> <h2>Release notes:</h2> <h3>Bug Fixes</h3> <ul> <li><strong>headers:</strong> fixed isValidHeaderName to support full list of allowed characters; (<a href="https://redirect.github.com/axios/axios/issues/5584">#5584</a>) (<a href="https://github.com/axios/axios/commit/e7decef6a99f4627e27ed9ea5b00ce8e201c3841">e7decef</a>)</li> <li><strong>params:</strong> re-added the ability to set the function as <code>paramsSerializer</code> config; (<a href="https://redirect.github.com/axios/axios/issues/5633">#5633</a>) (<a href="https://github.com/axios/axios/commit/a56c8661209d5ce5a645a05f294a0e08a6c1f6b3">a56c866</a>)</li> </ul> <h3>Contributors to this release</h3> <ul> <li> <a href="https://github.com/DigitalBrainJS" title="+28/-10 ([#5633](axios/axios#5633) [#5584](axios/axios#5584) )">Dmitriy Mozgovoy</a></li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/axios/axios/blob/v1.x/CHANGELOG.md">axios's changelog</a>.</em></p> <blockquote> <h2><a href="https://github.com/axios/axios/compare/v1.3.4...v1.3.5">1.3.5</a> (2023-04-05)</h2> <h3>Bug Fixes</h3> <ul> <li><strong>headers:</strong> fixed isValidHeaderName to support full list of allowed characters; (<a href="https://redirect.github.com/axios/axios/issues/5584">#5584</a>) (<a href="https://github.com/axios/axios/commit/e7decef6a99f4627e27ed9ea5b00ce8e201c3841">e7decef</a>)</li> <li><strong>params:</strong> re-added the ability to set the function as <code>paramsSerializer</code> config; (<a href="https://redirect.github.com/axios/axios/issues/5633">#5633</a>) (<a href="https://github.com/axios/axios/commit/a56c8661209d5ce5a645a05f294a0e08a6c1f6b3">a56c866</a>)</li> </ul> <h3>Contributors to this release</h3> <ul> <li> <a href="https://github.com/DigitalBrainJS" title="+28/-10 ([#5633](axios/axios#5633) [#5584](axios/axios#5584) )">Dmitriy Mozgovoy</a></li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/axios/axios/commit/4af78a72eee06172c53383aaed74e2dcaf44d620"><code>4af78a7</code></a> chore(release): v1.3.5 (<a href="https://redirect.github.com/axios/axios/issues/5634">#5634</a>)</li> <li><a href="https://github.com/axios/axios/commit/a56c8661209d5ce5a645a05f294a0e08a6c1f6b3"><code>a56c866</code></a> fix(params): re-added the ability to set the function as <code>paramsSerializer</code> c...</li> <li><a href="https://github.com/axios/axios/commit/e7decef6a99f4627e27ed9ea5b00ce8e201c3841"><code>e7decef</code></a> fix(headers): fixed isValidHeaderName to support full list of allowed charact...</li> <li>See full diff in <a href="https://github.com/axios/axios/compare/v1.3.4...v1.3.5">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=axios&package-manager=npm_and_yarn&previous-version=1.3.4&new-version=1.3.5)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

gfichtenholt added 5 commits October 26, 2022 03:09

add integration test

ab0d287

add integration test

2eeb31e

Merge branch 'main' into flux-incremental-2

1dd5547

bump flux version

085a723

incremental

a49287d

vmwclabot added the cla-not-required label Oct 28, 2022

gfichtenholt self-assigned this Oct 28, 2022

gfichtenholt linked an issue Oct 28, 2022 that may be closed by this pull request

A flux app in failed install state, deleted via UX, stays around in k8s flux HelmRelease CR #5577

Open

gfichtenholt added 3 commits October 28, 2022 00:32

incremental

e9597c9

Merge branch 'main' into flux-incremental-2

df19645

available package handling with flux in multi-tenant mode vmware-tan…

6336e0f

…zu#5541

gfichtenholt linked an issue Nov 3, 2022 that may be closed by this pull request

available package handling with flux in multi-tenant mode #5541

Closed

antgamdia approved these changes Nov 4, 2022

View reviewed changes

Antonio's feedback

864dffb

gfichtenholt merged commit c160190 into vmware-tanzu:main Nov 5, 2022

gfichtenholt deleted the flux-incremental-2 branch November 5, 2022 02:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Part of the fix for a flux app in failed install state, deleted via UX, stays around in k8s flux HelmRelease CR #5577 #5584

Part of the fix for a flux app in failed install state, deleted via UX, stays around in k8s flux HelmRelease CR #5577 #5584

gfichtenholt commented Oct 28, 2022 •

edited

netlify bot commented Oct 28, 2022 •

edited

antgamdia left a comment

gfichtenholt commented Nov 4, 2022

Part of the fix for a flux app in failed install state, deleted via UX, stays around in k8s flux HelmRelease CR #5577 #5584

Part of the fix for a flux app in failed install state, deleted via UX, stays around in k8s flux HelmRelease CR #5577 #5584

Conversation

gfichtenholt commented Oct 28, 2022 • edited

netlify bot commented Oct 28, 2022 • edited

✅ Deploy Preview for kubeapps-dev ready!

antgamdia left a comment

Choose a reason for hiding this comment

gfichtenholt commented Nov 4, 2022

gfichtenholt commented Oct 28, 2022 •

edited

netlify bot commented Oct 28, 2022 •

edited