New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run GHA's Full Integration Pipeline on schedule #5621
Run GHA's Full Integration Pipeline on schedule #5621
Conversation
Signed-off-by: Jesús Benito Calzada <bjesus@vmware.com>
✅ Deploy Preview for kubeapps-dev canceled.Built without sensitive environment variables
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you know which TZ GH actions are running on?
I assume this is just for testing on GKE, the step for building nightly ARM images is still pending, no?
Perhaps not now, and don't know if it is possible: what about comparing the commit with which the CI was run the last time against the current commit we wanna test; if they are the same, skip it. Otherwise, run the action.
With this, we could run the workflow every night while assuming we won't be testing the same twice.
@antgamdia I'm sorry but I'm afraid I don't understand your comment 😓 What
Yeah, they're different things. This is for running the
mmm, I'm not sure if that's even possible... In case it was, I think it would increase the complexity of the pipeline just to avoid testing more than once on the same commit, for a workflow that is run three times per week. Do you think it would be worth it? |
Sorry, I should have been more clear. I just wanted to know in which timezone (TZ) the GitHub Actions (GHA) run. I was slightly concern about it as we have teammates around the globe, so in case of reaching a sort of concurrency limit (not sure if it applies also to GHA), we would be hindering the work of our colleagues if the TZ is not taken into account.
Great, thanks for clarifying!
Not sure, perhaps it is not worth it as you pointed out. At the end of the day, is not that critical (we don't need to be testing it continuously), so I'm more than ok with the current approach. |
I'm not 100% sure, but I would say that GHA uses UTC time. Besides that, there wouldn't be any problem in running the pipeline at any time as there's no such concurrency limit. The only concurrency limitation as of today is that a new run of the workflow would cancel the one currently running, but only a new run of the very same workflow. I mean, running a workflow for a PR or a push to |
It seems that |
Signed-off-by: Jesús Benito Calzada bjesus@vmware.com
Description of the change
Run the GitHub Action's
Full Integration Pipeline
on schedule. We usually run this pipeline manually only when we are going to release a new version of Kubeapps, and from time to time it turns out that it fails.Benefits
With this change, we get a much shorter feedback loop, so we can act on the errors more proactively.
Possible drawbacks
An increase in cloud costs due to the fact of running the tests more frequently. Is that a problem?
Applicable issues
Additional information
N/A