Add SRP source provenance report #5632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beni0888
added
component/ci
✅ Deploy Preview for kubeapps-dev canceled.Built without sensitive environment variables
|
Signed-off-by: Jesús Benito Calzada <bjesus@vmware.com>
Signed-off-by: Jesús Benito Calzada <bjesus@vmware.com>
Signed-off-by: Jesús Benito Calzada <bjesus@vmware.com>
beni0888
force-pushed
the
gha-srp-report
branch
from
4d7944d
to
d963bd9
Compare
absoludity
approved these changes
Nov 15, 2022
There was a problem hiding this comment.
LGTM, small question about srp client version but +1 either way. Thanks @beni0888
| run: | | ||
| set -u | ||
| mkdir -p /tmp/srp-cli | ||
| curl https://srp-cli.s3.amazonaws.com/srp-cli-latest.tgz -o /tmp/srp-cli/srp-cli-latest.tgz |
There was a problem hiding this comment.
Should we use a specific version rather than latest for the client here?
There was a problem hiding this comment.
Mmm TBH, I'm not sure about that, but taking into account that in the CircleCI version we're pointing to a specific version, I guess you're right. Changing it before merging. Thanks for the heads up!
Signed-off-by: Jesús Benito Calzada <bjesus@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jesús Benito Calzada bjesus@vmware.com
Description of the change
This PR adds the required SRP source provenance report to the GHA pipeline. Currently, the report is being done in the CircleCI pipeline, but as part of the migration to GHA, we need to implement it there. For this report to work, we need to register a new SRP UID for GHA, which will be something like
uid.mtd.provenance_2_5.fragment(obj_uid=uid.obj.build.github(instance='github.com',namespace='vmware-tanzu/kubeapps',...),version=''). An issue has been created in the Jira Service Desk for this task, and we will maintain this PR as a draft until that request is fulfilled.Benefits
Possible drawbacks
None.
Applicable issues
Additional information