Extract custom default values from package tarball #5702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Nelson <minelson@vmware.com>
Signed-off-by: Michael Nelson <minelson@vmware.com>
✅ Deploy Preview for kubeapps-dev canceled.
|
Signed-off-by: Michael Nelson <minelson@vmware.com>
dlaloue-vmware
approved these changes
Nov 29, 2022
| @@ -4582,6 +4574,14 @@ | |||
| "description": "An example of default values used during package templating that can serve\nas documentation or a starting point for user customization.", | |||
| "title": "Available package default values" | |||
| }, | |||
| "customDefaultValues": { | |||
There was a problem hiding this comment.
this is just a suggestion, but maybe we can use a more neutral word? The description is using the term extra for example, another term could be "additional" or "alternate"?
There was a problem hiding this comment.
I'd go for "additional" (as they are layered on top) rather than "alternate" (as they are not instead of), but yep, "additional" is good for me (better than "custom"). I'll update to that. Thanks.
Signed-off-by: Michael Nelson <minelson@vmware.com>
Signed-off-by: Michael Nelson <minelson@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This PR begins the work specified in #5692 by updating the
AvailablePackageDetailmessage to include custom default values and updating the tar utils so that they are fetched and returned (if present) when the other files are fetched from a tarball.Benefits
Possible drawbacks
Applicable issues
Additional information