Revert and fix so that latest tag is used in dev chart PRs. #6237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Nelson <minelson@vmware.com>
✅ Deploy Preview for kubeapps-dev canceled.
|
antgamdia
added a commit
that referenced
this pull request
Aug 10, 2023
### Description of the change This PR is to actually fix #6220 by fetching from DockerHub the more recent (!=latest) published tag. I'm removing the workaround performed in #6237. ### Benefits The script will continue to work as initially expected. ### Possible drawbacks N/A ### Applicable issues - fixes #6220 ### Additional information N/A Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
After getting a couple of dev chart auto-created PRs like #6236, which are doing nothing except setting our development images from
latest(which they should be in the dev chart) to a fixed version, I realised that in #6221 I'd actually updated the incorrect part of the script.This PR fixes that, by ensuring that we don't refer to
taginreplaceImage_latestToProductionsince we don't have the production values of the tag currently (until we update to use the dockerhub API as per #6220) - this was the intended change of the previous PR - and reverts the unintended change that updatedreplaceImage_productionToLatestso that we again expectlatestfor our own images in the dev chart.Benefits
We're no longer bothered by noop PRs such as #6236 .
Possible drawbacks
Applicable issues
Additional information