Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the remaining non-connect error functionality. #6336

Merged
merged 6 commits into from Jun 27, 2023

Conversation

absoludity
Copy link
Contributor

Description of the change

This is the final PR removing all the existing grpc status codes from the kubeapps-apis service.

Benefits

Dashboard client interprets the correct errors.

Applicable issues

Signed-off-by: Michael Nelson <minelson@vmware.com>
Signed-off-by: Michael Nelson <minelson@vmware.com>
Signed-off-by: Michael Nelson <minelson@vmware.com>
Signed-off-by: Michael Nelson <minelson@vmware.com>
Signed-off-by: Michael Nelson <minelson@vmware.com>
@netlify
Copy link

netlify bot commented Jun 27, 2023

Deploy Preview for kubeapps-dev canceled.

Name Link
🔨 Latest commit 22d0160
🔍 Latest deploy log https://app.netlify.com/sites/kubeapps-dev/deploys/649a5992577d99000896685e

Signed-off-by: Michael Nelson <minelson@vmware.com>
@absoludity absoludity merged commit 5d8f735 into main Jun 27, 2023
39 checks passed
@absoludity absoludity deleted the 6269-correct-error-code-try2.7 branch June 27, 2023 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auth loop when no admin permissions set on default namespace
2 participants