Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed baseUrl to use relative path to support URL subpath #6525

Merged
merged 1 commit into from Jul 26, 2023

Conversation

jcatana
Copy link
Contributor

@jcatana jcatana commented Jul 26, 2023

Description of the change

Fixes static baseUrl: /... to be relative baseUrl: ./...

Benefits

Restores previous functionality of working behind url subpath aka ingress

Possible drawbacks

Unknown

Applicable issues

Additional information

@netlify
Copy link

netlify bot commented Jul 26, 2023

Deploy Preview for kubeapps-dev canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit a3f3922
🔍 Latest deploy log https://app.netlify.com/sites/kubeapps-dev/deploys/64c0a07894ab310008a6e809

@vmwclabot
Copy link

@jcatana, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

@vmwclabot
Copy link

@jcatana, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed.

@vmwclabot
Copy link

@jcatana, VMware has rejected your signed contributor license agreement. The merge can not proceed until the agreement has been resigned. Click here to resign the agreement. Reject reason:

Can you please provide the following Address info. - Country, State, Town/City. Thanks

@absoludity
Copy link
Contributor

Thanks @jcatana . I'm assuming you tested this in real life and verified that it fixes the issue without breaking anything else. Looks like we just switched to an absolute path when upgrading as mentioned on the issue. I'll let the CI tooling run for now, while you get to do the joys of signing the CLA (apologies for the friction to contribute :) )

@absoludity
Copy link
Contributor

Looks good @jcatana , once the CLA is done I'll approve and land. Thanks!

@vmwclabot
Copy link

@jcatana, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed.

@jcatana
Copy link
Contributor Author

jcatana commented Jul 26, 2023

Updated. Autocomplete only puts street & number in "address" fields. Maybe a fix to the CLA if you require all that info. Can I make a PR on your CLA form? 🤣

@vmwclabot
Copy link

@jcatana, VMware has approved your signed contributor license agreement.

@absoludity
Copy link
Contributor

Updated. Autocomplete only puts street & number in "address" fields. Maybe a fix to the CLA if you require all that info. Can I make a PR on your CLA form? 🤣

I wish - not something we control. Thanks again!

@absoludity absoludity merged commit a3333d3 into vmware-tanzu:main Jul 26, 2023
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Path hosted kubeapps behind Ingress provided by nginx on AKS
3 participants