Remove old js components: Checkbox, Input, Tooltip #6539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
✅ Deploy Preview for kubeapps-dev canceled.Built without sensitive environment variables
|
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
antgamdia
changed the title
absoludity
approved these changes
Aug 1, 2023
antgamdia
added a commit
that referenced
this pull request
Aug 4, 2023
### Description of the change This PR is following up #6539. In this one, the focus is on: - Transforming `Row` and `Column` to tsx components. - Update some imports - Transform the `useOutsideClick` hook to typescript. - I saw there is a [library with useful hooks](https://usehooks.com/useclickaway), but since we just have this one, adding yet another dep maybe is not worth it. - Remove an unnecessary `isSomeResourceLoading` helper and its folder structure After those changes, I decided to stop and continue in another PR (the upcoming changes are more extensive than these ones). ### Benefits I don't have any cool before/after shots in this PR :P, but I do have a minor improvement in the `useOutsideClick`: now it also responds to touch events: https://github.com/vmware-tanzu/kubeapps/assets/11535726/b13d2e68-9fbc-4ab1-87ad-9593a17d2370 ### Possible drawbacks N/A (hope any!) ### Applicable issues Related to #6563 ### Additional information N/A --------- Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This is to replace some old js components we used to have. They were created before the ones provided by Clarity existed.
For making this PR somehow bearable, I'm just adding the following changes:
<CdsInput>.react-tooltip, but there were some occurrences of this custom component. I have replaced each one and fixed the unit tests.Benefits
Have a look at the following before/after pics:
Input
Tooltip 1
Tooltip 2
Tooltip 3
Tooltip 4
Tooltip 5
Possible drawbacks
Applicable issues
Can't recall the long-term issue we had for migrating to CDS :SRelated to #6563
Additional information
The remaining js components are:
They will be either replaced (ex Alert->AlertGroup, maybe) or migrated to typescript if possible.