Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow oci:// protocol to be specified for OCI AppRepositories #6645

Merged
merged 4 commits into from Aug 20, 2023

Conversation

absoludity
Copy link
Contributor

@absoludity absoludity commented Aug 17, 2023

Description of the change

When OCI support was added originally, we required people to specify an http/https URL for the registry, even though Helm itself allows oci://, because we're (Kubeapps) actually interacting with the OCI distribution spec in that code.

In addition, there was an issue in the dashboard that even if you did specify oci://registry-1.docker.io/foo the dashboard would assume the URI was missing a protocol since it doesn't start with http and add it, resulting in https://oci://registry-1.docker.io/foo.

This PR fixes the dashboard issue (so you can specify an oci protocol), updates the validation in the kubeapps-apis to use https in that case, and the sync code to do the same.

  • TODO: check that the oci catalog handles it as well. (all good - the grpc API only takes the host and namespace etc.

Benefits

Users can specify the OCI registry the way they would with Helm or other tools (this actually tripped up someone trying it out recently).

Possible drawbacks

Bugs?

Applicable issues

Signed-off-by: Michael Nelson <minelson@vmware.com>
Signed-off-by: Michael Nelson <minelson@vmware.com>
Signed-off-by: Michael Nelson <minelson@vmware.com>
@netlify
Copy link

netlify bot commented Aug 17, 2023

Deploy Preview for kubeapps-dev canceled.

Name Link
🔨 Latest commit b9ba861
🔍 Latest deploy log https://app.netlify.com/sites/kubeapps-dev/deploys/64ddb886b671720008369e0b

Signed-off-by: Michael Nelson <minelson@vmware.com>
Copy link
Contributor

@antgamdia antgamdia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

I just remembered we had an open issue partially related to this code (the repo validation, in general). I'm referencing it just in case we wanted to have a look at: #5781

@absoludity absoludity merged commit 51adff0 into main Aug 20, 2023
41 of 42 checks passed
@absoludity absoludity deleted the 6263-interlude-6427-enable-oci-proto branch August 20, 2023 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support oci:// as the protocol when adding an OCI registry/namespace source
3 participants