Removing httpclient.Client interface. #6746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Nelson <minelson@vmware.com>
✅ Deploy Preview for kubeapps-dev canceled.
|
absoludity
added a commit
that referenced
this pull request
Sep 5, 2023
### Description of the change Follows on from #6746 removing more uses of the httpclient.Client test interface that's causing pain when adding new features, and updates tests to use an `httptest.Server` instead of mocking the client. ### Benefits See #6726 Also fixes more tests that were feigning to assert that errors were equal, but were simply asserting that an error was raised. ### Possible drawbacks ### Applicable issues - fixes #6726 ### Additional information ~~One more PR following which removes the remainder and the interface itself.~~ (Ended up just adding to this PR). --------- Signed-off-by: Michael Nelson <minelson@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Part 1 removing the httpclient.Client interface. See #6726 for which this is needed.
Benefits
Able to write code that expects a plain http.Client.
Better tests.
Possible drawbacks
Applicable issues
Additional information