Disable SRP action from Kubeapps #7064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for kubeapps-dev failed.Built without sensitive environment variables
|
antgamdia
reviewed
Nov 10, 2023
Comment on lines
-604
to
-606
| SRP_CLI_VERSION: ${{env.SRP_CLI_VERSION}} | ||
| SRP_CLIENT_ID: ${{secrets.SRP_CLIENT_ID}} | ||
| SRP_CLIENT_SECRET: ${{secrets.SRP_CLIENT_SECRET}} |
There was a problem hiding this comment.
Maybe we should delete these vars (SRP_CLI_VERSION, SRP_CLIENT_ID and SRP_CLIENT_SECRET) from other places as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Due announcement that starting on Nov. 13 (Monday), calls to the 2.5 APIs will return a 400 error message. This means that the SRPCLI commands to submit provenance 2.5 will begin to fail, which in turn may fail your build.
The implementation of calls to v3 directly from Bitnami makes unnecessary to double-check in Kubeapps development pipelines.
Benefits
SRP process is centralized in the official assets for Kubeapps and not necessary in the development ones.
Possible drawbacks
N/A