Upgrade js deps #7208
Merged
Upgrade js deps #7208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
antgamdia
added
dependencies
✅ Deploy Preview for kubeapps-dev canceled.Built without sensitive environment variables
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This PR is upgrading some JS deps at once, mainly to prevent many ongoing dependabot PRs.
Benefits
Deps will be up to date.
Possible drawbacks
A quick IRL test shows that everything seems to be fine, but let's see what CI thinks.
Applicable issues
N/A
Additional information
I've been unable to upgrade these two:
@clr/ui: the new CSS styles break the current UI (bigger fonts, weights, etc), so some manual changes are required.react-markdownplus theremark-xxxdeps: they require React 18 and/or a proper ESM compatible test engine (time to move from Jest?)