Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the create and patch service logic in haprovider #317

Open
6 tasks
lubronzhan opened this issue Jun 28, 2024 · 0 comments
Open
6 tasks

Refactor the create and patch service logic in haprovider #317

lubronzhan opened this issue Jun 28, 2024 · 0 comments

Comments

@lubronzhan
Copy link
Contributor

Bug description
The haprovider logic is not correctly createAndPatch service. some of the fields won't be patched after created. it should use something like below to correctly patch service in case service is modified incorrectly by human

https://github.com/kubernetes-sigs/cluster-api-provider-vsphere/blob/main/pkg/services/vimmachine.go#L310-L374

Affected product area (please put an X in all that apply)

  • Docs
  • Installation
  • Plugin
  • Security
  • Test and Release
  • User Experience

Expected behavior

Steps to reproduce the bug

Version (include the SHA if the version is not obvious)

Environment where the bug was observed (cloud, OS, etc)

Relevant Debug Output (Logs, manifests, etc)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant