You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We could stay with go 1.17, which is no longer supported. We could bump to go 1.18, which is slightly newer but there's no compelling reason not to make it all the way to go 1.19. Note that this simply affects semantics, since the build and runtime are still 1.19.
Are you considering submitting a PR for this feature?
Yes.
Additional context
TODO:
Use any instead of interface{}?
Explore use of generics
Remove psets in favor of k8s.io/apimachinery/pkg/util/sets
Use atomic.Bool from Golang stdlib instead of an uber lib (this is technically separate but we should do it anyways!)
The text was updated successfully, but these errors were encountered:
Is your feature request related to a problem? Please describe.
Keep things up to date. Remove extraneous code and/or simplify existing code.
Describe the solution you'd like
All go.mod files use
go 1.19
. https://go.dev/doc/modules/gomod-ref#goDescribe alternatives you've considered
We could stay with
go 1.17
, which is no longer supported. We could bump togo 1.18
, which is slightly newer but there's no compelling reason not to make it all the way togo 1.19
. Note that this simply affects semantics, since the build and runtime are still1.19
.Are you considering submitting a PR for this feature?
Yes.
Additional context
TODO:
any
instead ofinterface{}
?psets
in favor ofk8s.io/apimachinery/pkg/util/sets
atomic.Bool
from Golang stdlib instead of an uber lib (this is technically separate but we should do it anyways!)The text was updated successfully, but these errors were encountered: