Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to Golang 1.19 semantics #1375

Closed
joshuatcasey opened this issue Jan 19, 2023 · 1 comment
Closed

Bump to Golang 1.19 semantics #1375

joshuatcasey opened this issue Jan 19, 2023 · 1 comment
Assignees
Labels
chore Not a bug or an enhancement, but still a work item state/accepted All done!

Comments

@joshuatcasey
Copy link
Member

Is your feature request related to a problem? Please describe.

Keep things up to date. Remove extraneous code and/or simplify existing code.

Describe the solution you'd like

All go.mod files use go 1.19. https://go.dev/doc/modules/gomod-ref#go

Describe alternatives you've considered

We could stay with go 1.17, which is no longer supported. We could bump to go 1.18, which is slightly newer but there's no compelling reason not to make it all the way to go 1.19. Note that this simply affects semantics, since the build and runtime are still 1.19.

Are you considering submitting a PR for this feature?

Yes.

Additional context

TODO:

  • Use any instead of interface{}?
  • Explore use of generics
  • Remove psets in favor of k8s.io/apimachinery/pkg/util/sets
  • Use atomic.Bool from Golang stdlib instead of an uber lib (this is technically separate but we should do it anyways!)
@pinniped-ci-bot pinniped-ci-bot added enhancement New feature or request priority/undecided Not yet prioritized chore Not a bug or an enhancement, but still a work item and removed enhancement New feature or request labels Jan 19, 2023
@pinniped-ci-bot pinniped-ci-bot changed the title [Chore] Bump to Golang 1.19 semantics Bump to Golang 1.19 semantics Jan 20, 2023
@pinniped-ci-bot pinniped-ci-bot added priority/backlog Prioritized for an upcoming iteration state/started Someone is working on it currently and removed priority/undecided Not yet prioritized labels Jan 20, 2023
@pinniped-ci-bot pinniped-ci-bot added state/accepted All done! and removed priority/backlog Prioritized for an upcoming iteration state/started Someone is working on it currently labels Jan 30, 2023
@pinniped-ci-bot pinniped-ci-bot added priority/backlog Prioritized for an upcoming iteration state/started Someone is working on it currently and removed state/accepted All done! labels Jan 30, 2023
@joshuatcasey
Copy link
Member Author

This was closed with #1372

@pinniped-ci-bot pinniped-ci-bot added state/accepted All done! and removed priority/backlog Prioritized for an upcoming iteration state/started Someone is working on it currently labels Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Not a bug or an enhancement, but still a work item state/accepted All done!
Projects
None yet
Development

No branches or pull requests

2 participants