Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump k8s deps to 0.26 and bump generated code to include 1.26 #1372

Merged
merged 4 commits into from Jan 19, 2023

Conversation

cfryanr
Copy link
Member

@cfryanr cfryanr commented Jan 18, 2023

Addresses #1374.

Release note:

bump k8s deps to 0.26

@codecov
Copy link

codecov bot commented Jan 18, 2023

Codecov Report

Merging #1372 (23f6dd4) into main (3b46547) will decrease coverage by 0.02%.
The diff coverage is 64.28%.

@@            Coverage Diff             @@
##             main    #1372      +/-   ##
==========================================
- Coverage   75.50%   75.49%   -0.02%     
==========================================
  Files         167      167              
  Lines       14855    14857       +2     
==========================================
  Hits        11217    11217              
- Misses       3347     3350       +3     
+ Partials      291      290       -1     
Impacted Files Coverage Δ
internal/controllerlib/option.go 22.00% <0.00%> (-0.69%) ⬇️
internal/upstreamoidc/upstreamoidc.go 90.14% <0.00%> (ø)
cmd/pinniped-server/main.go 100.00% <100.00%> (ø)
internal/concierge/impersonator/impersonator.go 82.54% <100.00%> (ø)
internal/controller/kubecertagent/kubecertagent.go 92.68% <100.00%> (ø)
...l/controller/kubecertagent/pod_command_executor.go 86.66% <100.00%> (-0.44%) ⬇️
internal/plog/config.go 61.11% <0.00%> (+1.85%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cfryanr cfryanr force-pushed the jtc/support-k8s-0.26-and-bump-generated-code branch from a92a20a to 7ff3b3d Compare January 18, 2023 22:39
@cfryanr
Copy link
Member Author

cfryanr commented Jan 18, 2023

In CI, when we use the latest go-boringcrypto compiler (currently Go 1.18), this PR fails to compile. The error is:

#17 28.37 # k8s.io/component-base/metrics
#17 28.37 /go/pkg/mod/k8s.io/component-base@v0.26.0/metrics/registry.go:35:29: undefined: atomic.Bool
#17 28.37 note: module requires Go 1.19

It seems that this k8s package is using a new atomic.Bool type that only exists in Go 1.19: https://github.com/kubernetes/kubernetes/blob/v1.26.0/staging/src/k8s.io/component-base/metrics/registry.go#L35

Co-authored-by: Ryan Richard <richardry@vmware.com>
Co-authored-by: Joshua Casey <joshuatcasey@gmail.com>
@cfryanr
Copy link
Member Author

cfryanr commented Jan 19, 2023

Updated the fips build to use Go 1.19 in this PR to avoid the issue mentioned above.

@joshuatcasey
Copy link
Member

joshuatcasey commented Jan 19, 2023

I created #1375 to capture removing psets in favor of k8s.io/apimachinery/pkg/util/sets (amongst other things)

internal/kubeclient/kubeclient_test.go Show resolved Hide resolved
internal/controllerlib/option.go Show resolved Hide resolved
internal/upstreamoidc/upstreamoidc.go Show resolved Hide resolved
@cfryanr cfryanr merged commit 0ffd01d into main Jan 19, 2023
@cfryanr cfryanr deleted the jtc/support-k8s-0.26-and-bump-generated-code branch January 19, 2023 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants