Upgrade project Go dependencies #1353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1353 +/- ##
==========================================
- Coverage 76.89% 76.77% -0.13%
==========================================
Files 165 166 +1
Lines 14526 14581 +55
==========================================
+ Hits 11170 11194 +24
- Misses 3069 3096 +27
- Partials 287 291 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Most of the changes in this commit are because of these fosite PRs which changed behavior and/or APIs in fosite: - ory/fosite#667 - ory/fosite#679 (from me!) - ory/fosite#675 - ory/fosite#688 Due to the changes in fosite PR #688, we need to bump our storage version for anything which stores the DefaultSession struct as JSON.
cfryanr
force-pushed
the
dump_deps_dec_2022
branch
from
51e4e24
to
9760351
Compare
joshuatcasey
approved these changes
Dec 14, 2022
There was a problem hiding this comment.
A bit scary to see over 3000 LOC delta just due to dependency bumps.
I suspect in the future we can ease the pain by introducing smaller changes with each Dependabot PR.
There are a lot of lines such as Added line ... was not covered by tests, approving I'm curious about that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade several project Go dependencies. This PR will replace several Dependabot PRs.
Most of the changes in this PR are because of these fosite PRs which changed behavior and/or APIs in fosite:
at_hashclaim from appearing in the ID token from an authcode grant for some storage implementations ory/fosite#679 (from me!)ory_at|pt|acprefixes to HMAC tokens ory/fosite#675Note that due to the changes in ory/fosite#688, we need to bump our storage version for anything which stores the DefaultSession struct as JSON. This will cause end user sessions to be invalid after upgrading to a version of the Supervisor which includes this PR. Users will be prompted to log in again.
Release note: