Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly confirm informers have synced with timeout #137

Closed
wants to merge 1 commit into from

Conversation

enj
Copy link
Contributor

@enj enj commented Oct 1, 2020

Signed-off-by: Monis Khan mok@vmware.com

Signed-off-by: Monis Khan <mok@vmware.com>
Copy link
Member

@pinniped-ci-bot pinniped-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI

Copy link
Contributor

@mattmoyer mattmoyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good -- this code could use more tests but this PR doesn't meaningfully effect coverage either way.

@mattmoyer
Copy link
Contributor

Closing this since it's pretty bit-rotted, but I filed #654 for followup.

@mattmoyer mattmoyer closed this Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants