-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Debugging page to docs website #1824
Conversation
Good idea to document this. I think it might make more sense at the bottom of this page https://pinniped.dev/docs/howto/login/ which is where we show how to use the |
That sounds reasonable to me. |
c56bd5d
to
fbd69ae
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1824 +/- ##
==========================================
+ Coverage 38.56% 38.69% +0.12%
==========================================
Files 350 335 -15
Lines 44514 43626 -888
==========================================
- Hits 17168 16879 -289
+ Misses 26831 26244 -587
+ Partials 515 503 -12 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, just add the note about how to edit the log level inside the configmap
fbd69ae
to
6718a32
Compare
|
||
### Using kapp | ||
|
||
To adjust the log level of the Pinniped Supervisor or Concierge using `kapp`, edit the `log_level` in the `values.yaml` files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you meant to say using ytt
, not using kapp
.
And you don't edit the values.yaml file. See the other docs for instructions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, yeah I see we tell users to create a NEW values.yaml
file and add just the config they desire to change:
# ./my-supervisor-values.yaml
#@data/values
---
image_tag: v0.29.0
log_level: debug
replicas: 1
And then something ytt --file /path/to/pinniped/deploy/supervisor --file ./my-supervisor-values.yaml
# ... | ||
``` | ||
|
||
And then apply your configuration via `kubectl apply -f`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After applying the configuration, you must also restart the pods for the change to get picked up.
This whole section might make more sense if you split it into two sections: one for updating the log level for the Supervisor and another for updating the log level for the Concierge. The commands are slightly different, and the file that you show above would actually not have both configmaps in it if you use the commands that you show above to create the files.
TODO:
rm -rf ~/.config/pinniped
trick to this page, for "logging out", clearing caches, etc.Release note: