Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Debugging page to docs website #1824

Merged
merged 2 commits into from
Mar 27, 2024
Merged

Conversation

benjaminapetersen
Copy link
Member

@benjaminapetersen benjaminapetersen commented Jan 2, 2024

Uploading Screenshot 2024-03-27 at 5.05.00 PM.png…

TODO:

  • Lets change this to a dedicated debugging page
    • Move the env var to this page
    • Add the debugging yaml to this page
    • Add the rm -rf ~/.config/pinniped trick to this page, for "logging out", clearing caches, etc.

Release note:


@cfryanr
Copy link
Member

cfryanr commented Jan 2, 2024

Good idea to document this. I think it might make more sense at the bottom of this page https://pinniped.dev/docs/howto/login/ which is where we show how to use the pinniped CLI.

@benjaminapetersen
Copy link
Member Author

I'd even consider an additional "Debugging" page where we document this env var as well as the YAML changes to enable debugging for server side components.

Screenshot 2024-01-02 at 4 30 24 PM

@cfryanr
Copy link
Member

cfryanr commented Jan 4, 2024

I'd even consider an additional "Debugging" page where we document this env var as well as the YAML changes to enable debugging for server side components.

That sounds reasonable to me.

@benjaminapetersen benjaminapetersen force-pushed the ben/site/pinniped-debug-env branch 2 times, most recently from c56bd5d to fbd69ae Compare February 15, 2024 16:10
Copy link

codecov bot commented Feb 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.69%. Comparing base (f0a43e0) to head (fbd69ae).

❗ Current head fbd69ae differs from pull request most recent head 6718a32. Consider uploading reports for the commit 6718a32 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1824      +/-   ##
==========================================
+ Coverage   38.56%   38.69%   +0.12%     
==========================================
  Files         350      335      -15     
  Lines       44514    43626     -888     
==========================================
- Hits        17168    16879     -289     
+ Misses      26831    26244     -587     
+ Partials      515      503      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@joshuatcasey joshuatcasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just add the note about how to edit the log level inside the configmap

@joshuatcasey joshuatcasey merged commit 146e61e into main Mar 27, 2024
13 of 36 checks passed
@joshuatcasey joshuatcasey deleted the ben/site/pinniped-debug-env branch March 27, 2024 21:17

### Using kapp

To adjust the log level of the Pinniped Supervisor or Concierge using `kapp`, edit the `log_level` in the `values.yaml` files
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you meant to say using ytt, not using kapp.

And you don't edit the values.yaml file. See the other docs for instructions.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yeah I see we tell users to create a NEW values.yaml file and add just the config they desire to change:

# ./my-supervisor-values.yaml

#@data/values
---
image_tag: v0.29.0
log_level: debug
replicas: 1

And then something ytt --file /path/to/pinniped/deploy/supervisor --file ./my-supervisor-values.yaml

# ...
```

And then apply your configuration via `kubectl apply -f`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After applying the configuration, you must also restart the pods for the change to get picked up.

This whole section might make more sense if you split it into two sections: one for updating the log level for the Supervisor and another for updating the log level for the Concierge. The commands are slightly different, and the file that you show above would actually not have both configmaps in it if you use the commands that you show above to create the files.

@benjaminapetersen benjaminapetersen changed the title Add Debugging subheading to Install CLI page Add Debugging page to docs website Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants