WebhookAuthenticator .Status and validation improvements #1894

benjaminapetersen · 2024-03-13T16:06:02Z

Release note:

Adds meaningful .Status to WebhookAuthenticator resource.  Improves validations.

codecov · 2024-03-13T16:22:20Z

Codecov Report

Attention: Patch coverage is 80.39773% with 69 lines in your changes are missing coverage. Please review.

Project coverage is 38.57%. Comparing base (4465810) to head (c6b0820).

Files	Patch %	Lines
test/testlib/client.go	0.00%	37 Missing ⚠️
...enticator/webhookcachefiller/webhookcachefiller.go	94.65%	12 Missing and 1 partial ⚠️
internal/controller/utilserr.go	0.00%	9 Missing ⚠️
internal/testutil/stringutil.go	0.00%	5 Missing ⚠️
internal/controllermanager/prepare_controllers.go	0.00%	4 Missing ⚠️
...onfig/oidcupstreamwatcher/oidc_upstream_watcher.go	66.66%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1894      +/-   ##
==========================================
+ Coverage   38.25%   38.57%   +0.32%     
==========================================
  Files         347      350       +3     
  Lines       44207    44514     +307     
==========================================
+ Hits        16910    17171     +261     
- Misses      26785    26828      +43     
- Partials      512      515       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

benjaminapetersen · 2024-03-13T17:26:42Z

Cross reference to the JWT Authenticator status and validations as they are related:

#1851

internal/testutil/conciergetestutil/tlstestutil.go

internal/testutil/testlogger/loglines.go

test/testlib/client.go

test/integration/concierge_credentialrequest_test.go

test/integration/concierge_webhookauthenticator_status_test.go

internal/controller/authenticator/webhookcachefiller/webhookcachefiller.go

test/integration/concierge_webhookauthenticator_status_test.go

internal/controller/authenticator/webhookcachefiller/webhookcachefiller_test.go

internal/controller/authenticator/webhookcachefiller/webhookcachefiller.go

internal/controller/authenticator/webhookcachefiller/webhookcachefiller_test.go

internal/controller/authenticator/webhookcachefiller/webhookcachefiller.go

internal/controller/authenticator/webhookcachefiller/webhookcachefiller_test.go

internal/controller/authenticator/webhookcachefiller/webhookcachefiller.go

internal/controller/authenticator/webhookcachefiller/webhookcachefiller_test.go

- Add WebhookAuthenticator unit tests, update generated code - Add validateTLSNegotiation(), update tests - Update validateTLSNegotiation, add unit tests, factor out helpers - Update generated code

- total api fields test 260->261

Co-authored-by: Benjamin A. Petersen <ben@benjaminapetersen.me>

…onProbeValid

…itional IPv6 cases

internal/controller/authenticator/webhookcachefiller/webhookcachefiller.go

test/integration/concierge_webhookauthenticator_status_test.go

internal/controller/authenticator/webhookcachefiller/webhookcachefiller_test.go

internal/controller/authenticator/jwtcachefiller/jwtcachefiller.go

internal/endpointaddr/endpointaddr.go

- Carefully note the rfc27732 design for IPv6 in URLs, while also clarifying the handling of IPv6 in Golang. Co-authored-by: Ryan Richard <richardry@vmware.com>

- ConnectionProbeValid -> WebhookConnectionValid - This is to conform with the pattern of other controllers, ex: LDAPConnectionValid

vmwclabot added the cla-not-required label Mar 13, 2024

benjaminapetersen force-pushed the ben/status/webhook-authenticator branch from 1e6e159 to 8148985 Compare March 13, 2024 16:07

benjaminapetersen changed the title ~~Ben/status/webhook authenticator~~ WebhookAuthenticator .Status and validation improvements Mar 13, 2024

benjaminapetersen force-pushed the ben/status/webhook-authenticator branch from efbcef4 to dfa9d25 Compare March 13, 2024 17:10