Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI also skips authcode prompt when PINNIPED_SKIP_PRINT_LOGIN_URL=true #1938

Merged
merged 1 commit into from
May 7, 2024

Conversation

cfryanr
Copy link
Member

@cfryanr cfryanr commented May 7, 2024

Follow-up to #1897 to make the CLI also skip printing the authcode prompt when PINNIPED_SKIP_PRINT_LOGIN_URL=true. This allows the use of PINNIPED_SKIP_PRINT_LOGIN_URL=true with the Pinniped Supervisor (and other OIDC providers who use response_mode=form_post), which would have prompted for the authcode before this PR, potentially corrupting a console-based UI like k9s.

Release note:


Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.39%. Comparing base (c494add) to head (c86a615).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1938   +/-   ##
=======================================
  Coverage   29.39%   29.39%           
=======================================
  Files         350      350           
  Lines       58518    58513    -5     
=======================================
- Hits        17203    17202    -1     
+ Misses      40800    40797    -3     
+ Partials      515      514    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joshuatcasey joshuatcasey merged commit bc5eb3c into main May 7, 2024
42 checks passed
@joshuatcasey joshuatcasey deleted the skip_auth_url_also_skips_authcode_prompt branch May 7, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants