Cleanup go.mod replace directives that are no longer needed.
#786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #786 +/- ##
=======================================
Coverage 79.37% 79.37%
=======================================
Files 127 127
Lines 8639 8639
=======================================
Hits 6857 6857
+ Misses 1559 1558 -1
- Partials 223 224 +1
Continue to review full report at Codecov.
|
|
132d909 does not look valid to me since we pick up |
We don't anymore, it turns out: $ go list -deps all | grep -F "jwt-go"
github.com/form3tech-oss/jwt-go |
mattmoyer
force-pushed
the
cleanup-go-mod
branch
3 times, most recently
from
842c8ba
to
1b5aeb7
Compare
enj
approved these changes
Aug 17, 2021
mattmoyer
force-pushed
the
cleanup-go-mod
branch
2 times, most recently
from
6a53e05
to
80c7e0a
Compare
This is essentially reverting 87c7e89. Signed-off-by: Matt Moyer <moyerm@vmware.com>
This is reverting 8358c26. Signed-off-by: Matt Moyer <moyerm@vmware.com>
We no longer have a transitive dependency on this older repository, so we don't need the replace directive anymore. There is a new fork of this that we should move to (https://github.com/golang-jwt/jwt), but we can't easily do that until a couple of our direct dependencies upgrade. This is a revert of d162cb9. Signed-off-by: Matt Moyer <moyerm@vmware.com>
mattmoyer
force-pushed
the
cleanup-go-mod
branch
from
80c7e0a
to
03a8160
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes several
replacedirectives that we previously needed to make sure we got a working and secure set of Go module dependencies. Due to some of our recent direct and transitive dependency upgrades, it turns out we can remove all of these!I confirmed manually that the output of
go list -deps -json allwas identical before and after these changes.Release note: