test/integration: run parallel tests concurrently with serial tests #808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #808 +/- ##
=======================================
Coverage 79.15% 79.15%
=======================================
Files 128 128
Lines 8768 8768
=======================================
Hits 6940 6940
Misses 1604 1604
Partials 224 224 Continue to review full report at Codecov.
|
enj
force-pushed
the
enj/t/integration_parallel
branch
from
fc046eb
to
8df8379
Compare
enj
changed the title
enj
force-pushed
the
enj/t/integration_parallel
branch
from
8df8379
to
7c9680f
Compare
enj
changed the title
enj
force-pushed
the
enj/t/integration_parallel
branch
6 times, most recently
from
4e7a6fb
to
8fe60c8
Compare
cfryanr
reviewed
Aug 26, 2021
test/integration/main_test.go
Outdated
| for _, test := range tests { | ||
| test := test | ||
|
|
||
| if strings.Contains(test.Name, "Parallel") { |
There was a problem hiding this comment.
@enj It looks like you meant to say "ends with _Parallel" here, so we don't accidentally classify TestMyParallelFunctionality as one of these special tests.
There was a problem hiding this comment.
Or maybe "ends with _Parallel OR contains _Parallel/"?
There was a problem hiding this comment.
Oh I was being a bit lazy here, I can change it to "ends with _Parallel"
Signed-off-by: Monis Khan <mok@vmware.com>
Instead of blindly waiting long enough for a disruptive change to have been observed by the old leader and followers, we instead rely on the approximation that checkOnlyLeaderCanWrite provides - i.e. only a single actor believes they are the leader. This does not account for clients that were in the followers list before and after the disruptive change, but it serves as a reasonable approximation. Signed-off-by: Monis Khan <mok@vmware.com>
enj
force-pushed
the
enj/t/integration_parallel
branch
from
9cc90a3
to
e2cf9f6
Compare
mattmoyer
approved these changes
Aug 26, 2021
cfryanr
added a commit
that referenced
this pull request
Sep 21, 2021
This was broken recently by the improvements in #808.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Monis Khan mok@vmware.com
Fixes #803
Fixes #351
Release note: