Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upstreamoidc: log claim keys at debug level #853

Merged
merged 1 commit into from
Sep 29, 2021

Conversation

enj
Copy link
Contributor

@enj enj commented Sep 28, 2021

At debug level:

upstreamoidc.go:213] "claims from ID token and userinfo"
providerName="oidc"
keys=[at_hash aud email email_verified exp iat iss sub]

At all level:

upstreamoidc.go:207] "claims from ID token and userinfo"
providerName="oidc"
claims="{\"at_hash\":\"C55S-BgnHTmr2_TNf...hYmVhYWESBWxvY2Fs\"}"

Signed-off-by: Monis Khan mok@vmware.com

Release note:

NONE

At debug level:

upstreamoidc.go:213] "claims from ID token and userinfo"
providerName="oidc"
keys=[at_hash aud email email_verified exp iat iss sub]

At all level:

upstreamoidc.go:207] "claims from ID token and userinfo"
providerName="oidc"
claims="{\"at_hash\":\"C55S-BgnHTmr2_TNf...hYmVhYWESBWxvY2Fs\"}"

Signed-off-by: Monis Khan <mok@vmware.com>
@enj
Copy link
Contributor Author

enj commented Sep 28, 2021

Logs from CI that assert that the user info endpoint is being called (but dex does not really do anything special for it).

./supervisor-5b5bb6678c-wwhs5.log
3194:I0928 17:16:50.009077       1 upstreamoidc.go:214] "claims from ID token" providerName="test-upstream-oidc-idp-g8bjs" keys=[at_hash aud c_hash email email_verified exp iat iss nonce sub]
3195:I0928 17:16:50.010268       1 upstreamoidc.go:214] "claims from ID token and userinfo" providerName="test-upstream-oidc-idp-g8bjs" keys=[at_hash aud c_hash email email_verified exp iat iss nonce sub]

@codecov
Copy link

codecov bot commented Sep 28, 2021

Codecov Report

Merging #853 (03bbc54) into main (ad8610f) will decrease coverage by 0.06%.
The diff coverage is 27.27%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #853      +/-   ##
==========================================
- Coverage   78.62%   78.55%   -0.07%     
==========================================
  Files         129      129              
  Lines        8976     8985       +9     
==========================================
+ Hits         7057     7058       +1     
- Misses       1691     1697       +6     
- Partials      228      230       +2     
Impacted Files Coverage Δ
internal/upstreamoidc/upstreamoidc.go 88.23% <27.27%> (-7.47%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad8610f...03bbc54. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants