Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix a unit test that always failed on my laptop #893

Merged
merged 1 commit into from
Nov 24, 2021
Merged

Conversation

cfryanr
Copy link
Member

@cfryanr cfryanr commented Nov 23, 2021

Try to make the GCP plugin config less sensitive to the setup of the computer on which it runs.

Release note:

NONE

Try to make the GCP plugin config less sensitive to the setup of the
computer on which it runs.
@codecov
Copy link

codecov bot commented Nov 23, 2021

Codecov Report

Merging #893 (e445400) into main (5a1de2f) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #893      +/-   ##
==========================================
+ Coverage   78.96%   78.99%   +0.02%     
==========================================
  Files         132      132              
  Lines        9510     9510              
==========================================
+ Hits         7510     7512       +2     
+ Misses       1747     1745       -2     
  Partials      253      253              
Impacted Files Coverage Δ
...l/localuserauthenticator/localuserauthenticator.go 57.20% <0.00%> (+0.93%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a1de2f...e445400. Read the comment docs.

@enj enj enabled auto-merge November 24, 2021 00:25
@enj enj merged commit aaf8470 into main Nov 24, 2021
@enj enj deleted the fix_unit_test branch November 24, 2021 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants