Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requirements-check: Review TAP #82

Open
johnSchnake opened this issue Dec 22, 2021 · 1 comment
Open

requirements-check: Review TAP #82

johnSchnake opened this issue Dec 22, 2021 · 1 comment

Comments

@johnSchnake
Copy link
Contributor

TAP has a number of checks that could potentially be automated. Investigate and make a list of checks with high likelihood of reuse.

@johnSchnake
Copy link
Contributor Author

From here:https://docs.vmware.com/en/VMware-Tanzu-Application-Platform/0.1/tap-0-1/GUID-install.html#prerequisites-0

Most of these have the core functionality already address. We would need to round out he provider checks (right now we can just check for kind; havnt validated the others work the same way).

The main takeaway from reviewing these was that the cluster requirements were different based on the platform used (e.g. aws vs azure). As a result, its unlikely an out-of-the-box plugin would just allow that level of configuration unless we make it abstract and just define a DSL for the checks that can be combined into logical combinations (e.g. (PROVIDER_IS AWS && ...) || (PROVIDER_IS KIND && ...)) which sounds like it would make it harder for everyone.

I'm thinking that TAP would most likely utilize the requirements-check/pkg to programatically write their own logic for the checks. So we do all the heavy lifting to code the checks then they can just call those methods as needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant