Skip to content

Commit

Permalink
Remove template and convert to code
Browse files Browse the repository at this point in the history
The template was getting increasingly complex due to various
options. Even though dealing with the types can be verbose,
it allows us to better break up each object and apply arbitrary
logic with better formatting.

- removed template
- create each object and serialize it manually

The golden files were updated only in in the following ways:
- files end with '---' rather than start with it
- YAML quoting is dictated by the yaml pkg and not manually by us
- fields were ordered alphabetically as intended
- YAML arrays were written as dictated by internals and not by us

Signed-off-by: John Schnake <jschnake@vmware.com>
  • Loading branch information
johnSchnake committed Dec 15, 2021
1 parent 9506d94 commit ae75211
Show file tree
Hide file tree
Showing 49 changed files with 1,255 additions and 1,134 deletions.
2 changes: 1 addition & 1 deletion go.mod
Expand Up @@ -4,7 +4,6 @@ go 1.16

require (
github.com/briandowns/spinner v1.6.1
github.com/c2h5oh/datasize v0.0.0-20171227191756-4eba002a5eae
github.com/elazarl/goproxy v0.0.0-20190911111923-ecfe977594f1 // indirect
github.com/gorilla/mux v1.7.3
github.com/hashicorp/go-version v1.2.0
Expand All @@ -30,4 +29,5 @@ require (
k8s.io/apimachinery v0.21.3
k8s.io/client-go v0.21.3
k8s.io/klog v1.0.0
sigs.k8s.io/yaml v1.2.0
)
2 changes: 0 additions & 2 deletions go.sum
Expand Up @@ -51,8 +51,6 @@ github.com/beorn7/perks v0.0.0-20180321164747-3a771d992973/go.mod h1:Dwedo/Wpr24
github.com/beorn7/perks v1.0.0/go.mod h1:KWe93zE9D1o94FZ5RNwFwVgaQK1VOXiVxmqh+CedLV8=
github.com/briandowns/spinner v1.6.1 h1:LBxHu5WLyVuVEtTD72xegiC7QJGx598LBpo3ywKTapA=
github.com/briandowns/spinner v1.6.1/go.mod h1://Zf9tMcxfRUA36V23M6YGEAv+kECGfvpnLTnb8n4XQ=
github.com/c2h5oh/datasize v0.0.0-20171227191756-4eba002a5eae h1:2Zmk+8cNvAGuY8AyvZuWpUdpQUAXwfom4ReVMe/CTIo=
github.com/c2h5oh/datasize v0.0.0-20171227191756-4eba002a5eae/go.mod h1:S/7n9copUssQ56c7aAgHqftWO4LTf4xY6CGWt8Bc+3M=
github.com/census-instrumentation/opencensus-proto v0.2.1/go.mod h1:f6KPmirojxKA12rnyqOA5BBL4O983OfeGPqjHWSTneU=
github.com/cespare/xxhash v1.1.0/go.mod h1:XrSqR1VqqWfGrhpAt58auRo0WTKS1nRRg3ghfAqPWnc=
github.com/chzyer/logex v1.1.10/go.mod h1:+Ywpsq7O8HXn0nuIou7OrIPyXbp3wmkHB+jjWRnGsAI=
Expand Down

0 comments on commit ae75211

Please sign in to comment.