Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit test fails only locally if you have kind #1345

Closed
johnSchnake opened this issue Jul 2, 2021 · 0 comments · Fixed by #1346
Closed

Unit test fails only locally if you have kind #1345

johnSchnake opened this issue Jul 2, 2021 · 0 comments · Fixed by #1346
Labels
area/testing Related to testing Sonobuoy

Comments

@johnSchnake
Copy link
Contributor

Unit test fails locally if you have kind set up; this is becuase the unit test assumes you dont have a valid cluster but in your real environment you do.

See TestGetClusterVersion/Empty_gets_resolved_...
@johnSchnake johnSchnake added the area/testing Related to testing Sonobuoy label Jul 2, 2021
@johnSchnake johnSchnake mentioned this issue Jul 2, 2021
Merged
johnSchnake added a commit that referenced this issue Jul 2, 2021
@johnSchnake
Fix a unit test by avoiding local kubeconfig
9f293f2 
The test naturally picks up on the local kubeconfig so we need
to intentionally set it to a "bad" value here.

Fixes #1345

Signed-off-by: John Schnake <jschnake@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/testing Related to testing Sonobuoy
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix a unit test by avoiding local kubeconfig
1 participant
@johnSchnake