Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rationalize some tests issues upstream. #17

Closed
timothysc opened this issue Aug 3, 2017 · 11 comments
Closed

Rationalize some tests issues upstream. #17

timothysc opened this issue Aug 3, 2017 · 11 comments
Assignees
Labels
kind/bug Behavior isn't as expected or intended lifecycle/active Actively being worked on p1-important

Comments

@timothysc
Copy link
Contributor

The Kubectl tests were purposefully disabled for a number of reasons and we should move to rationalize this with upstream.

  1. I don't actually consider them conformance tests, but more aggregated behavioral tests
  2. They require passing in kubeconfig vs. leveraging in-cluster config
    ...

Also there are other tests, including the scheduler tests that I think need to be cherry-picked back to a 1.7 release.

@timothysc timothysc added kind/bug Behavior isn't as expected or intended p1-important labels Aug 3, 2017
@timothysc timothysc added this to the v0.9.0 milestone Aug 3, 2017
@timothysc timothysc self-assigned this Aug 3, 2017
@timothysc
Copy link
Contributor Author

We should also target 0.9.0 against 1.8-kube-release

@timothysc
Copy link
Contributor Author

timothysc commented Sep 5, 2017

@chuckha Here is the list of items that would need to get done in order to version match.

@timothysc
Copy link
Contributor Author

I'm working on this now along with other 1.8 closeout work.

@timothysc timothysc added the lifecycle/active Actively being worked on label Sep 7, 2017
@jlamillan
Copy link

Is there a way to pass in the kubeconfig so that these tests can be run?

@timothysc
Copy link
Contributor Author

@jlamillan I'm working to try and remove that requirement and leverage the in-cluster config.

The only tests that seem to leverage it heavily are the kubectl tests that I'm aware of.

@jlamillan
Copy link

@timothysc Ok, thanks. So, as of now, it is not possible to successfully run the kubectl tests in containerized Sonobuoy?

@timothysc
Copy link
Contributor Author

You "can" but it's very ugly, and requires a container mod.

@timothysc
Copy link
Contributor Author

Hmm I got ping's on another channel about KUBECONFIG, I'll start cleaning up the plumbing for back-support of 1.6 versions.

@jlamillan
Copy link

Thanks... very nice work here BTW.

@rbankston
Copy link
Contributor

Seems that the networking test for kubernetes conformance isn't very robust we might want to not run that test or have it made to work without icmp upstream

@timothysc
Copy link
Contributor Author

Flakes from 1.7 were addressed and comments from feedback were also addressed I'll open an tracking issue re: the network test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Behavior isn't as expected or intended lifecycle/active Actively being worked on p1-important
Projects
None yet
Development

No branches or pull requests

4 participants