Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version specific conformance test images #68

Closed
jrnt30 opened this issue Aug 29, 2017 · 4 comments
Closed

Version specific conformance test images #68

jrnt30 opened this issue Aug 29, 2017 · 4 comments
Assignees
Labels
kind/enhancement New or improved functionality p1-important

Comments

@jrnt30
Copy link
Contributor

jrnt30 commented Aug 29, 2017

Currently the e2e plugin suggests that it is not advisable to run the E2E suite on clusters < 1.7+ due to the upstream issue of not having gates around the tests that are available. Instead of relying on that upstream change to be made and people "doing the right thing" all the time, would it be possible to simply have a multi-version build for the kube-conformance image, where each is tagged for the appropriate K8 version?

Selfishly I would like to use this on a few 1.6 clusters however it also seems like it may be a bit more stable.

The main deficiency I see is if there are newer tests created to validate additional aspects of the cluster that are compatible with lower environments, those changes wouldn't be included.

@bzub
Copy link

bzub commented Aug 31, 2017

I just happen to have a PR open about this: heptio/kube-conformance#2

You can try out my changes, I'd be happy to hear how it works for you. You'd have to upload images to your own repo.

@timothysc
Copy link
Contributor

We can/should do both.

We've already pushed gates upstream which detect version and api capability, but we should also version our kube-conformance container for multiple versions.

I'm ooto this week, but will update shortly.
/cc @kensimon

@timothysc timothysc added kind/enhancement New or improved functionality p1-important labels Aug 31, 2017
@timothysc timothysc added this to the v0.9.0 milestone Aug 31, 2017
@timothysc timothysc self-assigned this Aug 31, 2017
@timothysc
Copy link
Contributor

This is linked with #17 so I'm going to close this one and try to test across revisions.

@timothysc
Copy link
Contributor

@jrnt30 did you have a list of tests that you saw failing btw.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New or improved functionality p1-important
Projects
None yet
Development

No branches or pull requests

4 participants