Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load plugins from a given URL #986

Closed
johnSchnake opened this issue Nov 7, 2019 · 0 comments · Fixed by #989
Closed

Load plugins from a given URL #986

johnSchnake opened this issue Nov 7, 2019 · 0 comments · Fixed by #989
Assignees
Milestone

Comments

@johnSchnake
Copy link
Contributor

Describe the solution you'd like
When someone specifies the --plugin flag it can currently be:

  • a known word like e2e or systemd-logs
  • a name of a local file which holds the plugin definition

I think a 3rd option should be supported to aid in sharing/experimenting with plugins: loading from a URL.

Anything else you would like to add:
I think this is pretty trivial to do; we just need to check the string and see if it parses as a URL. If it does, do a GET to the URL and the response body is the io.Reader that we can pass around.

This would not be the most secure feature since the user could be targeting a URL they haven't verified the contents of or they could be subject to MITM attacks but I think this is still a useful, feature to make experimentation/sharing more simple.

@johnSchnake johnSchnake added this to the v0.16.4 milestone Nov 7, 2019
@johnSchnake johnSchnake self-assigned this Nov 7, 2019
johnSchnake added a commit that referenced this issue Nov 12, 2019
We currently allow loading plugins from the local file system
but for sharing of plugins it makes sense to allow users to
specify a URL.

Fixes #986

Signed-off-by: John Schnake <jschnake@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant