Add command to output default image registry config #1022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the subcommand `default-image-config` to `gen` to output the default image registry config used with the `images` and `run` commands. It will generate the config based on the version of Kubernetes that is configured for use. This simplifies the process for users as the registries for the E2E tests differ for different versions of Kubernetes. Signed-off-by: Bridget McErlean <bmcerlean@vmware.com>
zubron
force-pushed
the
add-default-repo-config-command-1010
branch
from
19aaebf
to
ec8166b
Compare
Codecov Report
@@ Coverage Diff @@
## master #1022 +/- ##
==========================================
+ Coverage 48.33% 48.41% +0.08%
==========================================
Files 76 77 +1
Lines 5437 5498 +61
==========================================
+ Hits 2628 2662 +34
- Misses 2651 2675 +24
- Partials 158 161 +3
Continue to review full report at Codecov.
|
johnSchnake
approved these changes
Dec 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This adds the subcommand
default-image-configtogento output thedefault image registry config used with the
imagesandruncommands.It will generate the config based on the version of Kubernetes that is
configured for use.
This simplifies the process for users as the registries for the E2E
tests differ for different versions of Kubernetes.
Signed-off-by: Bridget McErlean bmcerlean@vmware.com
Which issue(s) this PR fixes
Special notes for your reviewer:
I included some tests for checking that the version verification worked however I didn't write tests to check the resulting registry lists as these seemed to just duplicate the code. I'm happy to add them though if it seems worth it.
Release note: