Use logrus for logs, write them into the snapshot #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The logs will be stored in "meta/run.log" as JSON-formatted log lines The kubernetes client's logs (which use glog) aren't included since there's no good way to redirect those. We can consider changing our docs to drop the `-v 5 --logtostderr` from the command line, since it only shows kube-client logs now. Signed-off-by: Ken Simon <ninkendo@gmail.com>
Signed-off-by: Ken Simon <ninkendo@gmail.com>
|
fixes #55 |
jhamilton1
pushed a commit
to jhamilton1/sonobuoy
that referenced
this pull request
Jun 27, 2018
Use logrus for logs, write them into the snapshot Signed-off-by: Jesse Hamilton jesse.hamilton@heptio.com
jhamilton1
pushed a commit
to jhamilton1/sonobuoy
that referenced
this pull request
Jun 27, 2018
Use logrus for logs, write them into the snapshot Signed-off-by: Jesse Hamilton jesse.hamilton@heptio.com Signed-off-by: Jesse Hamilton jesse.hamilton@heptio.com
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logs will be stored in "meta/run.log" as JSON-formatted log lines
The kubernetes client's logs (which use glog) aren't included since
there's no good way to redirect those. We can consider changing our
docs to drop the
-v 5 --logtostderrfrom the command line, since itonly shows kube-client logs now.
Signed-off-by: Ken Simon ninkendo@gmail.com