Update to disable collecting PodLogs by default & rev Conformance versions #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
due to expense and reported experience. Signed-off-by: Timothy St. Clair <timothysc@gmail.com>
|
@chuckha yes. updated. |
chuckha
approved these changes
Oct 2, 2017
| @@ -234,7 +233,7 @@ local e2eConfig = { | |||
| containers: [ | |||
| { | |||
| name: "e2e", | |||
| image: "gcr.io/heptio-images/kube-conformance:latest", | |||
| image: "gcr.io/heptio-images/kube-conformance:v1.8.0", | |||
There was a problem hiding this comment.
How is this related to the PodLogs?
There was a problem hiding this comment.
I was testing latest changes, and in a similar area. Just expedience.
jhamilton1
pushed a commit
to jhamilton1/sonobuoy
that referenced
this pull request
Jun 27, 2018
Update to disable collecting PodLogs by default & rev Conformance versions Signed-off-by: Jesse Hamilton jesse.hamilton@heptio.com
jhamilton1
pushed a commit
to jhamilton1/sonobuoy
that referenced
this pull request
Jun 27, 2018
Update to disable collecting PodLogs by default & rev Conformance versions Signed-off-by: Jesse Hamilton jesse.hamilton@heptio.com Signed-off-by: Jesse Hamilton jesse.hamilton@heptio.com
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to reported experience #82
However I was not able to repro a bug that was reported there.
Signed-off-by: Timothy St. Clair timothysc@gmail.com