Fixes #75 - Cleanup stale file handle #92
Conversation
pkg/worker/worker.go
Outdated
| @@ -36,6 +36,7 @@ import ( | |||
| func GatherResults(waitfile string, url string) error { | |||
| var inputFileName []byte | |||
| var err error | |||
| var outfile * os.File | |||
There was a problem hiding this comment.
It does, on save..
"go.formatOnSave": true,
"go.formatTool": "gofmt",
There was a problem hiding this comment.
weird!! When I save it it moves that * over to be var outfile *os.File
I literally don't care on this issue. Feel free to push.
pkg/worker/worker.go
Outdated
| return outfile, errors.WithStack(err) | ||
| err = DoRequest(url, func() (io.Reader, error) { | ||
| outfile, e2 := os.Open(s) | ||
| return outfile, errors.WithStack(e2) |
There was a problem hiding this comment.
I'm not sure about this; outfile on line 66 is in a different scope to line 39, so on line 70, outfile will always be nil.
I suggest
s/outfile/f here to make it clear that you're talking about a different variable.
| @@ -36,6 +36,7 @@ import ( | |||
| func GatherResults(waitfile string, url string) error { | |||
| var inputFileName []byte | |||
| var err error | |||
There was a problem hiding this comment.
delete this line, use err := on line 65
Signed-off-by: Timothy St. Clair <timothysc@gmail.com>
|
Thx for the quick review. |
| @@ -36,6 +36,7 @@ import ( | |||
| func GatherResults(waitfile string, url string) error { | |||
| var inputFileName []byte | |||
| var err error | |||
| var outfile *os.File | |||
|
|
|||
| // just loop looking for a file. | |||
| done := false | |||
There was a problem hiding this comment.
I know this is out of scope, but what about
for {
// do work
if err == nil {
// success!!
break
}
// log and wait
}
There was a problem hiding this comment.
Patches welcome ;-)
fwiw I didn't write this part of the code, I'm just trying to throw some fixes in before release.
| @@ -60,9 +61,16 @@ func GatherResults(waitfile string, url string) error { | |||
| url += "." + filenameParts[1] | |||
There was a problem hiding this comment.
line 45: inputFileName is misleading, it's not the name of a file, it's the contents of waitfile.
|
Noted, I'll be the change I seek.
…On Tue, Oct 3, 2017 at 8:51 AM, Timothy St. Clair ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In pkg/worker/worker.go
<#92 (comment)>:
> @@ -36,6 +36,7 @@ import (
func GatherResults(waitfile string, url string) error {
var inputFileName []byte
var err error
+ var outfile *os.File
// just loop looking for a file.
done := false
Patches welcome ;-)
fwiw I didn't write this part of the code, I'm just trying to throw some
fixes in before release.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#92 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAAcA_PIQgBq192fldEvNca4S5jyJfu7ks5soZMZgaJpZM4PrSXs>
.
|
Fixes vmware-tanzu#75 - Cleanup stale file handle Signed-off-by: Jesse Hamilton jesse.hamilton@heptio.com
Fixes vmware-tanzu#75 - Cleanup stale file handle Signed-off-by: Jesse Hamilton jesse.hamilton@heptio.com Signed-off-by: Jesse Hamilton jesse.hamilton@heptio.com
Fixes #75
Signed-off-by: Timothy St. Clair timothysc@gmail.com