Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial CircleCI config #940

Merged
merged 1 commit into from
Oct 9, 2019

Conversation

zubron
Copy link
Contributor

@zubron zubron commented Oct 7, 2019

This initial config replicates some of the steps from our TravisCI
config. It introduces a new workflow that contains 3 jobs. It currently
only handles the steps that take place on PR branches:

  • Checking that the READMEs are in sync
  • Checking the go module state
  • Running unit, stress, integration tests and a single Sonobuoy run

It does not yet handle image pushing. That will be addressed in a later
PR.

@codecov-io
Copy link

codecov-io commented Oct 7, 2019

Codecov Report

Merging #940 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #940   +/-   ##
=======================================
  Coverage   47.78%   47.78%           
=======================================
  Files          76       76           
  Lines        5226     5226           
=======================================
  Hits         2497     2497           
  Misses       2573     2573           
  Partials      156      156

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e18111d...94cf372. Read the comment docs.

@zubron zubron force-pushed the move-to-circle-ci-926 branch 28 times, most recently from 57e7c56 to af6cd35 Compare October 9, 2019 12:00
@zubron zubron changed the title WIP: Creating CircleCI config Add initial CircleCI config Oct 9, 2019
@zubron zubron marked this pull request as ready for review October 9, 2019 12:26
This initial config replicates some of the steps from our TravisCI
config. It introduces a new workflow that contains 3 jobs. It currently
only handles the steps that take place on PR branches:

* Checking that the READMEs are in sync
* Checking the go module state
* Running unit, stress, integration tests and the single Sonobuoy run

It does not yet handle image pushing. That will be addressed in a later
PR.

Signed-off-by: Bridget McErlean <bmcerlean@vmware.com>
@@ -0,0 +1,50 @@
#!/bin/bash

CI_SCRIPTS_DIR="$( cd "$( dirname "$0" )" >/dev/null 2>&1 && pwd )"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The contents of this scripts were taken as is from the existing travis-ci.sh script. It still uses the e2e command below. I would like to change that to use the new results command but thought that that should be part of a later change.

./scripts/ci/check_e2e_tarball.sh $tarball
mv $tarball /tmp/sonobuoy-tarball.tar.gz
- store_artifacts:
path: /tmp/sonobuoy-tarball.tar.gz
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you seeing the artifacts actually get uploaded? I dont see where to view them at
image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still curious about this, but I just opted-in to the new UI on CircleCI and the artifacts were visible:
image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you looking at the build job? The artifacts are only available within that one job. It's not very intuitive but they are being uploaded: https://circleci.com/gh/vmware-tanzu/sonobuoy/95#artifacts/containers/0

I don't know if there's a way to see all the artifacts from the workflow overview. I can take a look into that to see if there's a way to make that a bit clearer.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used the store_artifacts step. I guess I should use store_test_results instead: https://circleci.com/docs/2.0/configuration-reference/#store_test_results

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never mind, that seems to only be for specific test formats (JUnit, Cucumber etc)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still dont see them there for some reason. /shrug I'd think it was a permission issue but on the new view I can see them so it probably isnt that.

Devs are the only ones that really need to see them so if we both have some way of seeing it its fine with me. Wanted to make sure they were getting uploaded was all. I'll just use the updated UI

Copy link
Contributor

@johnSchnake johnSchnake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 So after this PR we'll follow up with:

  • getting docker image pushing (my task)
  • updating the scripts a bit
    • remove use of the e2e command
    • move the 'check tarball' stuff into just another integration test
    • use just a single kind cluster
    • investigate caching optimizations possible for all the go mod stuff

@zubron zubron merged commit 6899c87 into vmware-tanzu:master Oct 9, 2019
@zubron zubron deleted the move-to-circle-ci-926 branch October 9, 2019 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants