Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds new blog post regarding customizing the E2E test image #944

Merged
merged 1 commit into from
Oct 9, 2019
Merged

Adds new blog post regarding customizing the E2E test image #944

merged 1 commit into from
Oct 9, 2019

Conversation

johnSchnake
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Oct 9, 2019

Codecov Report

Merging #944 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #944   +/-   ##
=======================================
  Coverage   47.78%   47.78%           
=======================================
  Files          76       76           
  Lines        5226     5226           
=======================================
  Hits         2497     2497           
  Misses       2573     2573           
  Partials      156      156

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6899c87...7a7e93e. Read the comment docs.

@johnSchnake
Copy link
Contributor Author

Fixed a syntax error causing links to not generate properly; ready for final approval/merge.

Copy link
Contributor

@jonasrosland jonasrosland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor change requested, that's it. Looks great!

site/_posts/2019-10-09-Custom-E2E-Image.md Outdated Show resolved Hide resolved
Copy link
Contributor

@zubron zubron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a really great blog post, @johnSchnake!

site/_posts/2019-10-09-Custom-E2E-Image.md Outdated Show resolved Hide resolved
site/_posts/2019-10-09-Custom-E2E-Image.md Outdated Show resolved Hide resolved
site/_posts/2019-10-09-Custom-E2E-Image.md Outdated Show resolved Hide resolved
site/_posts/2019-10-09-Custom-E2E-Image.md Outdated Show resolved Hide resolved
site/_posts/2019-10-09-Custom-E2E-Image.md Outdated Show resolved Hide resolved
$ export k8sVersion=$(kubectl version -o json|jq .serverVersion.gitVersion -r)

# Download the existing run script as a starting place and change its mode to be executable.
$ curl https://raw.githubusercontent.com/kubernetes/kubernetes/master/cluster/images/conformance/run_e2e.sh -o run.sh && chmod +x run.sh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the downloaded script come from the matching Kubernetes version instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The script doesn't change much since it moved upstream; typically just bug fixes and such. I don't think it is a big deal to take the one from master.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's what I guessed but just wanted to check :)

Signed-off-by: John Schnake <jschnake@vmware.com>
@johnSchnake johnSchnake merged commit 03e44e6 into vmware-tanzu:master Oct 9, 2019
@johnSchnake johnSchnake deleted the customE2ETestImageBlog branch October 9, 2019 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants