Skip to content

Commit

Permalink
chore: Fix E2E tests when using upstream vcsim
Browse files Browse the repository at this point in the history
Closes: #453
Signed-off-by: Michael Gasch <15986659+embano1@users.noreply.github.com>
  • Loading branch information
embano1 committed Jul 8, 2022
1 parent 8e0c4a2 commit 7565872
Showing 1 changed file with 1 addition and 7 deletions.
8 changes: 1 addition & 7 deletions test/e2e/util.go
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ const (
user = "user"
password = "password"
jobNameKey = "job-name"
defaultVcsimImage = "vmware/vcsim:latest"
)

type envConfig struct {
Expand Down Expand Up @@ -492,11 +491,6 @@ func newSimulator(namespace, image string) (*appsv1.Deployment, *corev1.Service)
l := map[string]string{
"app": vcsim,
}
args := []string{"-l", ":8989"}
if image == defaultVcsimImage {
// vmware/vcsim image is built differently, it does not use ko. Therefore, the entrypoint is different.
args = append([]string{"/vcsim"}, args...)
}

sim := appsv1.Deployment{
ObjectMeta: metav1.ObjectMeta{
Expand All @@ -517,7 +511,7 @@ func newSimulator(namespace, image string) (*appsv1.Deployment, *corev1.Service)
Containers: []corev1.Container{{
Name: vcsim,
Image: image,
Args: args,
Args: []string{"-l", ":8989"},
ImagePullPolicy: corev1.PullIfNotPresent,
Ports: []corev1.ContainerPort{
{
Expand Down

0 comments on commit 7565872

Please sign in to comment.