Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support more data encoding schemes #222

Closed
embano1 opened this issue Mar 26, 2021 · 0 comments · Fixed by #252
Closed

Support more data encoding schemes #222

embano1 opened this issue Mar 26, 2021 · 0 comments · Fixed by #252

Comments

@embano1
Copy link
Contributor

embano1 commented Mar 26, 2021 •
edited

Currently, event payload is serialized as XML. This should be more flexible, e.g. to support JSON-encoded cloudevent data.
embano1 pushed a commit to embano1/sources-for-knative that referenced this issue Jun 2, 2021
Make data encoding configurable
c815757 
This change adds support for configurable CloudEvent dataencoding
schemes. Currently, only application/xml and application/JSON are
supported.

The default encoding (if unspecified) remains application/xml to
preserve backwards-compatibility.

The kn plugin has a new flag to configure this behavior. For ease of
use, "xml" or "json" are accepted, i.e. "application/" must not be
specified.

Closes: vmware-tanzu#222
Signed-off-by: Michael Gasch <mgasch@vmware.com>
@embano1 embano1 mentioned this issue Jun 2, 2021
Merged
vaikas pushed a commit that referenced this issue Jun 2, 2021
Make data encoding configurable (#252)
8b252bc 
This change adds support for configurable CloudEvent dataencoding
schemes. Currently, only application/xml and application/JSON are
supported.

The default encoding (if unspecified) remains application/xml to
preserve backwards-compatibility.

The kn plugin has a new flag to configure this behavior. For ease of
use, "xml" or "json" are accepted, i.e. "application/" must not be
specified.

Closes: #222
Signed-off-by: Michael Gasch <mgasch@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make data encoding scheme configurable embano1/sources-for-knative
1 participant
@embano1