Restructure VSphereSource
#395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #395 +/- ##
=======================================
Coverage 83.23% 83.23%
=======================================
Files 27 27
Lines 1032 1032
=======================================
Hits 859 859
Misses 146 146
Partials 27 27 Continue to review full report at Codecov.
|
Adding support for multiple sources by restructuring this source. Also removing pkg logstream because it was not working with the standard logging configuragion anymore. The zap configuration uses 'level' as the log level key, whereas logstream assumes 'severity'. Closes: vmware-tanzu#394 Signed-off-by: Michael Gasch <mgasch@vmware.com>
|
@gabo1208 @xtreme-sameer-vohra ready for review |
|
Is the logstream change related to this issue? #343 |
Nope. |
gabo1208
approved these changes
Mar 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #394
Proposed Changes
Sourcenaminglogstream(used in tests) broke and I removed itPre-review Checklist
Release Note