Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HorizonSource #416

Merged
merged 1 commit into from
Jul 6, 2022
Merged

Add HorizonSource #416

merged 1 commit into from
Jul 6, 2022

Conversation

embano1
Copy link
Contributor

@embano1 embano1 commented Apr 11, 2022

A new HorizonSource is available reusing most of the code running in production from the VMware Event Broker Appliance Horizon event processor.

Fixes #392

Proposed Changes

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior
  • Docs for any user-facing impact

Notes:

  • E2E tests are not possible due to missing Horizon simulator/API (unit tests use mocking)
  • Coverage decreases due to certain code paths only exercised in E2E tests (not implemented), e.g. deploying adapter for a HorizonSource

Release Note

A new source `HorizonSource` is available to retrieve events from VMware Horizon.

@embano1 embano1 changed the title WIP WIP: Add HorizonSource Apr 11, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 11, 2022

Codecov Report

Merging #416 (fc81a77) into main (9018e18) will decrease coverage by 15.38%.
The diff coverage is 35.07%.

@@             Coverage Diff             @@
##             main     #416       +/-   ##
===========================================
- Coverage   81.62%   66.23%   -15.39%     
===========================================
  Files          27       38       +11     
  Lines        1382     2070      +688     
===========================================
+ Hits         1128     1371      +243     
- Misses        226      655      +429     
- Partials       28       44       +16     
Impacted Files Coverage 螖
pkg/reconciler/horizonsource/controller.go 0.00% <0.00%> (酶)
pkg/reconciler/horizonsource/deployment.go 0.00% <0.00%> (酶)
pkg/reconciler/horizonsource/horizonsource.go 0.00% <0.00%> (酶)
pkg/reconciler/horizonsource/serviceaccount.go 0.00% <0.00%> (酶)
pkg/horizon/horizon.go 29.22% <29.22%> (酶)
pkg/apis/sources/v1alpha1/horizonsource_types.go 50.00% <50.00%> (酶)
...g/apis/sources/v1alpha1/horizonsource_lifecycle.go 52.00% <52.00%> (酶)
pkg/horizon/adapter.go 73.29% <73.29%> (酶)
.../apis/sources/v1alpha1/horizonsource_validation.go 82.50% <82.50%> (酶)
...kg/apis/sources/v1alpha1/horizonsource_defaults.go 100.00% <100.00%> (酶)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 9018e18...fc81a77. Read the comment docs.

@embano1 embano1 changed the title WIP: Add HorizonSource Add HorizonSource Jul 5, 2022
@embano1 embano1 marked this pull request as ready for review July 5, 2022 11:15
@embano1 embano1 requested a review from a team as a code owner July 5, 2022 11:15

### Deploy the Source

Finally, deploy the `HorizonSource`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This trailing spaces and I think is good to go


### Configure the Source

Modify the `horizon-source.yml` according to your environment.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

Closes: vmware-tanzu#392
Signed-off-by: Michael Gasch <mgasch@vmware.com>
Signed-off-by: Michael Gasch <15986659+embano1@users.noreply.github.com>
@gabo1208 gabo1208 merged commit f02e412 into vmware-tanzu:main Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add HorizonSource
3 participants