1.7 grpc CVE #530
Merged
1.7 grpc CVE #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| shift | ||
| target="${1?Need to provide a target branch argument}" | ||
|
|
||
| old=`fmktemp ${target}` |
There was a problem hiding this comment.
[shellcheck] reported by reviewdog 🐶
Suggested change
| old=`fmktemp ${target}` | |
| old=`fmktemp "${target}"` |
| old=`fmktemp ${target}` | ||
| bench "${target}" "${old}" | ||
|
|
||
| new=`fmktemp HEAD` |
There was a problem hiding this comment.
[shellcheck] reported by reviewdog 🐶
Suggested change
| new=`fmktemp HEAD` | |
| new=$(fmktemp HEAD) |
| -a) | ||
| shift | ||
|
|
||
| v2stats=`fmktemp go-toml-v2` |
There was a problem hiding this comment.
[shellcheck] reported by reviewdog 🐶
Suggested change
| v2stats=`fmktemp go-toml-v2` | |
| v2stats=$(fmktemp go-toml-v2) |
|
|
||
| v2stats=`fmktemp go-toml-v2` | ||
| bench HEAD "${v2stats}" "github.com/pelletier/go-toml/v2" | ||
| v1stats=`fmktemp go-toml-v1` |
There was a problem hiding this comment.
[shellcheck] reported by reviewdog 🐶
Suggested change
| v1stats=`fmktemp go-toml-v1` | |
| v1stats=$(fmktemp go-toml-v1) |
| bench HEAD "${v2stats}" "github.com/pelletier/go-toml/v2" | ||
| v1stats=`fmktemp go-toml-v1` | ||
| bench HEAD "${v1stats}" "github.com/pelletier/go-toml" | ||
| bsstats=`fmktemp bs-toml` |
There was a problem hiding this comment.
[shellcheck] reported by reviewdog 🐶
Suggested change
| bsstats=`fmktemp bs-toml` | |
| bsstats=$(fmktemp bs-toml) |
Comment on lines
+261
to
+263
| tmpcsv=`fmktemp csv` | ||
| benchstat -csv -geomean go-toml-v2.txt go-toml-v1.txt bs-toml.txt > $tmpcsv | ||
| benchstathtml $tmpcsv |
There was a problem hiding this comment.
[shellcheck] reported by reviewdog 🐶
Suggested change
| tmpcsv=`fmktemp csv` | |
| benchstat -csv -geomean go-toml-v2.txt go-toml-v1.txt bs-toml.txt > $tmpcsv | |
| benchstathtml $tmpcsv | |
| tmpcsv=$(fmktemp csv) | |
| benchstat -csv -geomean go-toml-v2.txt go-toml-v1.txt bs-toml.txt > "$tmpcsv" | |
| benchstathtml "$tmpcsv" |
| return $? | ||
| esac | ||
|
|
||
| bench "${1-HEAD}" `mktemp` |
There was a problem hiding this comment.
[shellcheck] reported by reviewdog 🐶
Suggested change
| bench "${1-HEAD}" `mktemp` | |
| bench "${1-HEAD}" $(mktemp) |
| @@ -0,0 +1,279 @@ | |||
| #!/usr/bin/env bash | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
[shfmt] reported by reviewdog 🐶
Suggested change
|
|
||
|
|
||
| stderr() { | ||
| echo "$@" 1>&2 |
There was a problem hiding this comment.
[shfmt] reported by reviewdog 🐶
Suggested change
| echo "$@" 1>&2 | |
| echo "$@" 1>&2 |
Comment on lines
+9
to
+10
| b=$(basename "$0") | ||
| echo $b: ERROR: "$@" 1>&2 |
There was a problem hiding this comment.
[shfmt] reported by reviewdog 🐶
Suggested change
| b=$(basename "$0") | |
| echo $b: ERROR: "$@" 1>&2 | |
| b=$(basename "$0") | |
| echo $b: ERROR: "$@" 1>&2 |
| b=$(basename "$0") | ||
| echo $b: ERROR: "$@" 1>&2 | ||
|
|
||
| cat 1>&2 <<EOF |
There was a problem hiding this comment.
[shfmt] reported by reviewdog 🐶
Suggested change
| cat 1>&2 <<EOF | |
| cat 1>&2 <<EOF |
| the BRANCH argument is required. Exit code is non-zero when | ||
| coverage percentage decreased. | ||
| EOF | ||
| exit 1 |
There was a problem hiding this comment.
[shfmt] reported by reviewdog 🐶
Suggested change
| exit 1 | |
| exit 1 |
Comment on lines
138
to
140
| awk '$1=="#define" && $2 ~ /^SIG[A-Z0-9]+$/ { print "^\t" $2 "[ \t]*=" }' | | ||
| egrep -v '(SIGSTKSIZE|SIGSTKSZ|SIGRT)' | | ||
| grep -v 'SIGSTKSIZE\|SIGSTKSZ\|SIGRT' | | ||
| sort >_signal.grep |
There was a problem hiding this comment.
[shfmt] reported by reviewdog 🐶
Suggested change
| awk '$1=="#define" && $2 ~ /^SIG[A-Z0-9]+$/ { print "^\t" $2 "[ \t]*=" }' | | |
| egrep -v '(SIGSTKSIZE|SIGSTKSZ|SIGRT)' | | |
| grep -v 'SIGSTKSIZE\|SIGSTKSZ\|SIGRT' | | |
| sort >_signal.grep | |
| awk '$1=="#define" && $2 ~ /^SIG[A-Z0-9]+$/ { print "^\t" $2 "[ \t]*=" }' | | |
| grep -v 'SIGSTKSIZE\|SIGSTKSZ\|SIGRT' | | |
| sort >_signal.grep |
Comment on lines
643
to
646
| echo '#include <signal.h>' | $CC -x c - -E -dM $ccflags | | ||
| awk '$1=="#define" && $2 ~ /^SIG[A-Z0-9]+$/ { print $2 }' | | ||
| egrep -v '(SIGSTKSIZE|SIGSTKSZ|SIGRT|SIGMAX64)' | | ||
| grep -v 'SIGSTKSIZE\|SIGSTKSZ\|SIGRT\|SIGMAX64' | | ||
| sort |
There was a problem hiding this comment.
[shfmt] reported by reviewdog 🐶
Suggested change
| echo '#include <signal.h>' | $CC -x c - -E -dM $ccflags | | |
| awk '$1=="#define" && $2 ~ /^SIG[A-Z0-9]+$/ { print $2 }' | | |
| egrep -v '(SIGSTKSIZE|SIGSTKSZ|SIGRT|SIGMAX64)' | | |
| grep -v 'SIGSTKSIZE\|SIGSTKSZ\|SIGRT\|SIGMAX64' | | |
| sort | |
| echo '#include <signal.h>' | $CC -x c - -E -dM $ccflags | | |
| awk '$1=="#define" && $2 ~ /^SIG[A-Z0-9]+$/ { print $2 }' | | |
| grep -v 'SIGSTKSIZE\|SIGSTKSZ\|SIGRT\|SIGMAX64' | | |
| sort |
Comment on lines
654
to
656
| awk '$1=="#define" && $2 ~ /^SIG[A-Z0-9]+$/ { print "^\t" $2 "[ \t]*=" }' | | ||
| egrep -v '(SIGSTKSIZE|SIGSTKSZ|SIGRT|SIGMAX64)' | | ||
| grep -v 'SIGSTKSIZE\|SIGSTKSZ\|SIGRT\|SIGMAX64' | | ||
| sort >_signal.grep |
There was a problem hiding this comment.
[shfmt] reported by reviewdog 🐶
Suggested change
| awk '$1=="#define" && $2 ~ /^SIG[A-Z0-9]+$/ { print "^\t" $2 "[ \t]*=" }' | | |
| egrep -v '(SIGSTKSIZE|SIGSTKSZ|SIGRT|SIGMAX64)' | | |
| grep -v 'SIGSTKSIZE\|SIGSTKSZ\|SIGRT\|SIGMAX64' | | |
| sort >_signal.grep | |
| awk '$1=="#define" && $2 ~ /^SIG[A-Z0-9]+$/ { print "^\t" $2 "[ \t]*=" }' | | |
| grep -v 'SIGSTKSIZE\|SIGSTKSZ\|SIGRT\|SIGMAX64' | | |
| sort >_signal.grep |
Comment on lines
+71
to
+73
| PATH="/home/travis/bin:${PATH}" make proto && \ | ||
| git status --porcelain 2>&1 | fail_on_output || \ | ||
| (git status; git --no-pager diff; exit 1) |
There was a problem hiding this comment.
[shfmt] reported by reviewdog 🐶
Suggested change
| PATH="/home/travis/bin:${PATH}" make proto && \ | |
| git status --porcelain 2>&1 | fail_on_output || \ | |
| (git status; git --no-pager diff; exit 1) | |
| PATH="/home/travis/bin:${PATH}" make proto && | |
| git status --porcelain 2>&1 | fail_on_output || | |
| ( | |
| git status | |
| git --no-pager diff | |
| exit 1 | |
| ) |
| SC_OUT="$(mktemp)" | ||
| staticcheck -go 1.9 -checks 'inherit,-ST1015' ./... > "${SC_OUT}" || true | ||
| staticcheck -go 1.19 -checks 'inherit,-ST1015,-ST1019,-SA1019' ./... > "${SC_OUT}" || true |
There was a problem hiding this comment.
[shfmt] reported by reviewdog 🐶
Suggested change
| staticcheck -go 1.19 -checks 'inherit,-ST1015,-ST1019,-SA1019' ./... > "${SC_OUT}" || true | |
| staticcheck -go 1.19 -checks 'inherit,-ST1015,-ST1019,-SA1019' ./... >"${SC_OUT}" || true |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated actions