-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
E2E tests for Sample plugin #508
Merged
chandrareddyp
merged 1 commit into
main
from
topic/chandra/e2e-framework-for-plugin-developers-2
Oct 24, 2023
Merged
E2E tests for Sample plugin #508
chandrareddyp
merged 1 commit into
main
from
topic/chandra/e2e-framework-for-plugin-developers-2
Oct 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chandrareddyp
changed the title
Topic/chandra/e2e framework for plugin developers 2
E2E framework changes and tests for sample-plugin
Sep 29, 2023
chandrareddyp
force-pushed
the
topic/chandra/e2e-framework-for-plugin-developers-2
branch
6 times, most recently
from
October 5, 2023 18:37
b181389
to
f430265
Compare
chandrareddyp
force-pushed
the
topic/chandra/e2e-framework-for-plugin-developers-2
branch
3 times, most recently
from
October 13, 2023 16:13
2a8703e
to
204a9d9
Compare
chandrareddyp
changed the title
E2E framework changes and tests for sample-plugin
E2E tests for Sample plugin
Oct 13, 2023
anujc25
reviewed
Oct 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @chandrareddyp for adding this. Overall looks great. Few minor comments.
anujc25
reviewed
Oct 24, 2023
This Pull request add below changes: -Creation of a 'sample-plugin' under the 'test' directory. -Addition of E2E test cases for the 'sample-plugin' to verify its functionality using the E2E framework API. -Add GitHub workflow to execute E2E test cases for the 'sample-plugin.' -CLI E2E framework enhancements to accommodate E2E testing for the 'sample-plugin.'
chandrareddyp
force-pushed
the
topic/chandra/e2e-framework-for-plugin-developers-2
branch
from
October 24, 2023 04:43
7204451
to
83737ea
Compare
anujc25
approved these changes
Oct 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
mpanchajanya
pushed a commit
that referenced
this pull request
Oct 24, 2023
This Pull request add below changes: -Creation of a 'sample-plugin' under the 'test' directory. -Addition of E2E test cases for the 'sample-plugin' to verify its functionality using the E2E framework API. -Add GitHub workflow to execute E2E test cases for the 'sample-plugin.' -CLI E2E framework enhancements to accommodate E2E testing for the 'sample-plugin.' (cherry picked from commit 152d6fd)
mpanchajanya
pushed a commit
that referenced
this pull request
Oct 24, 2023
This Pull request add below changes: -Creation of a 'sample-plugin' under the 'test' directory. -Addition of E2E test cases for the 'sample-plugin' to verify its functionality using the E2E framework API. -Add GitHub workflow to execute E2E test cases for the 'sample-plugin.' -CLI E2E framework enhancements to accommodate E2E testing for the 'sample-plugin.' (cherry picked from commit 152d6fd)
mpanchajanya
pushed a commit
that referenced
this pull request
Oct 24, 2023
This Pull request add below changes: -Creation of a 'sample-plugin' under the 'test' directory. -Addition of E2E test cases for the 'sample-plugin' to verify its functionality using the E2E framework API. -Add GitHub workflow to execute E2E test cases for the 'sample-plugin.' -CLI E2E framework enhancements to accommodate E2E testing for the 'sample-plugin.' (cherry picked from commit 152d6fd)
chandrareddyp
deleted the
topic/chandra/e2e-framework-for-plugin-developers-2
branch
November 14, 2023 17:55
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
This pull request implements the following changes:
The goal of this PR is to showcase the capabilities of the Tanzu CLI E2E framework for implementing end-to-end tests for plugin developers.
Which issue(s) this PR fixes
Fixes #
Describe testing done for PR
Release note
Additional information
Special notes for your reviewer