Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E tests for Sample plugin #508

Merged

Conversation

chandrareddyp
Copy link
Contributor

@chandrareddyp chandrareddyp commented Sep 29, 2023

What this PR does / why we need it

This pull request implements the following changes:

  • Creation of a 'sample-plugin' under the 'test' directory.
  • Addition of E2E test cases for the 'sample-plugin' to verify its functionality using the E2E framework API.
  • Add GitHub workflow to execute E2E test cases for the 'sample-plugin.'
  • CLI E2E framework enhancements to accommodate E2E testing for the 'sample-plugin.'

The goal of this PR is to showcase the capabilities of the Tanzu CLI E2E framework for implementing end-to-end tests for plugin developers.

Which issue(s) this PR fixes

Fixes #

Describe testing done for PR

  • We have added a GitHub workflow to execute E2E test cases, which cover both the sample plugin's functionality and the demonstration of E2E framework API usage.
  • The results of the sample plugin tests are also presented in the Github workflow.

Release note

A sample plugin with E2E test cases has been added to demonstrate the usage of the CLI E2E framework API. This addition is designed to help plugin developers quickly get started with the CLI E2E framework API.

Additional information

Special notes for your reviewer

@chandrareddyp chandrareddyp requested a review from a team as a code owner September 29, 2023 16:27
@chandrareddyp chandrareddyp changed the title Topic/chandra/e2e framework for plugin developers 2 E2E framework changes and tests for sample-plugin Sep 29, 2023
@chandrareddyp chandrareddyp force-pushed the topic/chandra/e2e-framework-for-plugin-developers-2 branch 6 times, most recently from b181389 to f430265 Compare October 5, 2023 18:37
@chandrareddyp chandrareddyp force-pushed the topic/chandra/e2e-framework-for-plugin-developers-2 branch 3 times, most recently from 2a8703e to 204a9d9 Compare October 13, 2023 16:13
@chandrareddyp chandrareddyp changed the title E2E framework changes and tests for sample-plugin E2E tests for Sample plugin Oct 13, 2023
Copy link
Contributor

@anujc25 anujc25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @chandrareddyp for adding this. Overall looks great. Few minor comments.

test/sample-plugin/CODEOWNERS Outdated Show resolved Hide resolved
test/sample-plugin/.markdownlint.json Outdated Show resolved Hide resolved
.github/workflows/cli_core_e2e_sample-plugin.yaml Outdated Show resolved Hide resolved
This Pull request add below changes:
-Creation of a 'sample-plugin' under the 'test' directory.
-Addition of E2E test cases for the 'sample-plugin' to verify its functionality using the E2E framework API.
-Add GitHub workflow to execute E2E test cases for the 'sample-plugin.'
-CLI E2E framework enhancements to accommodate E2E testing for the 'sample-plugin.'
@chandrareddyp chandrareddyp force-pushed the topic/chandra/e2e-framework-for-plugin-developers-2 branch from 7204451 to 83737ea Compare October 24, 2023 04:43
Copy link
Contributor

@anujc25 anujc25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chandrareddyp chandrareddyp merged commit 152d6fd into main Oct 24, 2023
9 checks passed
@marckhouzam marckhouzam added this to the v1.1.0 milestone Oct 24, 2023
mpanchajanya pushed a commit that referenced this pull request Oct 24, 2023
This Pull request add below changes:
-Creation of a 'sample-plugin' under the 'test' directory.
-Addition of E2E test cases for the 'sample-plugin' to verify its functionality using the E2E framework API.
-Add GitHub workflow to execute E2E test cases for the 'sample-plugin.'
-CLI E2E framework enhancements to accommodate E2E testing for the 'sample-plugin.'

(cherry picked from commit 152d6fd)
mpanchajanya pushed a commit that referenced this pull request Oct 24, 2023
This Pull request add below changes:
-Creation of a 'sample-plugin' under the 'test' directory.
-Addition of E2E test cases for the 'sample-plugin' to verify its functionality using the E2E framework API.
-Add GitHub workflow to execute E2E test cases for the 'sample-plugin.'
-CLI E2E framework enhancements to accommodate E2E testing for the 'sample-plugin.'

(cherry picked from commit 152d6fd)
mpanchajanya pushed a commit that referenced this pull request Oct 24, 2023
This Pull request add below changes:
-Creation of a 'sample-plugin' under the 'test' directory.
-Addition of E2E test cases for the 'sample-plugin' to verify its functionality using the E2E framework API.
-Add GitHub workflow to execute E2E test cases for the 'sample-plugin.'
-CLI E2E framework enhancements to accommodate E2E testing for the 'sample-plugin.'

(cherry picked from commit 152d6fd)
@chandrareddyp chandrareddyp deleted the topic/chandra/e2e-framework-for-plugin-developers-2 branch November 14, 2023 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants